Skip to content

v3: Fix RCU lockdep splats

Paul E. McKenney lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10rcu: v2: optionally leave lockdep enabled after RCU lockdep splatinclude/linux/rcupdate.h kernel/lockdep.c lib/Kconfig.debug+25 -40 replies
2/10KEYS: Fix an RCU warningsecurity/keys/request_key.c+8 -50 replies
3/10KEYS: Fix an RCU warning in the reading of user keyssecurity/keys/user_defined.c+2 -10 replies
4/10cgroup: Fix an RCU warning in cgroup_path()kernel/cgroup.c+9 -30 replies
5/10cgroup: Fix an RCU warning in alloc_css_id()kernel/cgroup.c+2 -20 replies
6/10sched: Fix an RCU warning in print_task()kernel/sched_debug.c+2 -00 replies
7/10cgroup: Check task_lock in task_subsys_state()include/linux/cgroup.h+1 -00 replies
8/10memcg: css_id() must be called under rcu_read_lock()mm/memcontrol.c+16 -54 replies
9/10blk-cgroup: Fix RCU correctness warning in cfq_init_queue()block/cfq-iosched.c+2 -00 replies
10/10vfs: fix RCU-lockdep false positive due to /proc accessinclude/linux/fdtable.h include/linux/rcupdate.h kernel/rcupdate.c+15 -10 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by.

PatchEric ParisMatt HelsleyEric DumazetMiles LaneLi Zefan
1/10Requested-by T-b
2/10A-b
3/10
4/10
5/10
6/10
7/10A-b
8/10T-b
9/10Located-by
10/10Located-by Located-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH tip/core/urgent 0/10] v3: Fix RCU lockdep splats

Hello!

This patchset reposts ten fixes for various lockdep splats. The only changes from v2 (http://lkml.org/lkml/2010/4/30/500) is the addition of relevant maintainers on CC and fixing the last patch to work correctly from modules. (Of course, if you would rather take the patch up your tree, please let me know.)

Thanx, Paul

o rcu: v2: optionally leave lockdep enabled after RCU lockdep splat
This is a repost that makes the one-splat-per-boot the default, but allows those who want multiple splats to get this behavior via a new CONFIG_PROVE_RCU_REPEATEDLY configuration parameter. (Original from Lai Jiangshan.)

o KEYS: Fix an RCU warning
KEYS: Fix an RCU warning in the reading of user keys Fixes for RCU-lockdep splats from David Howells for security/keys. Repost of http://lkml.org/lkml/2010/4/22/411.

o cgroup: Fix an RCU warning in cgroup_path()
cgroup: Fix an RCU warning in alloc_css_id()
sched: Fix an RCU warning in print_task()
cgroup: Check task_lock in task_subsys_state() Fixes for RCU-lockdep splats in cgroups and sched from Li Zefan.

o memcg: css_id() must be called under rcu_read_lock()
Fixes for RCU-lockdep splats in memcg from Kamazawa Hiroyuki.

o blk-cgroup: Fix RCU correctness warning in cfq_init_queue()
Fix for RCU-lockdep splat in I/O scheduler from Vivek Goyal.

o vfs: fix RCU-lockdep false positive due to /proc access
Fix for RCU-lockdep splat from fdtable.h, with much debugging assist from Eric Dumazet. Updated to provide a wrapper function for thread_group_empty() to continue to allow this to be callable from a module.

 b/block/cfq-iosched.c          |    2 ++
 b/include/linux/cgroup.h       |    1 +
 b/include/linux/fdtable.h      |    3 ++-
 b/include/linux/rcupdate.h     |   15 +++++++++++----
 b/kernel/cgroup.c              |   12 +++++++++---
 b/kernel/lockdep.c             |    2 ++
 b/kernel/rcupdate.c            |   11 +++++++++++
 b/kernel/sched_debug.c         |    2 ++
 b/lib/Kconfig.debug            |   12 ++++++++++++
 b/mm/memcontrol.c              |   21 ++++++++++++++++-----
 b/security/keys/request_key.c  |   13 ++++++++-----
 b/security/keys/user_defined.c |    3 ++-
 include/linux/rcupdate.h       |    2 ++
 kernel/cgroup.c                |    4 ++--
 14 files changed, 82 insertions(+), 21 deletions(-)