Skip to content

RFC UNIX domain socket fixes and other cleanups

Paul Moore selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6selinux: Update socket's label alongside inode's labelsecurity/selinux/hooks.c security/selinux/include/netlabel.h security/selinux/netlabel.c+46 -62 replies
2/6selinux: Set the peer label correctly on connected UNIX domain socketssecurity/selinux/hooks.c+12 -165 replies
3/6selinux: Consolidate sockcreate_sid logicsecurity/selinux/hooks.c+12 -204 replies
4/6selinux: Shuffle the sk_security_struct alloc and free routinessecurity/selinux/hooks.c+17 -280 replies
5/6selinux: Convert socket related access controls to use socket labelssecurity/selinux/hooks.c+46 -752 replies
6/6selinux: Use current_security() when possiblesecurity/selinux/hooks.c+6 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH v1 0/6] UNIX domain socket fixes and other cleanups

Hello all,

This patchset grew out of the SELinux UNIX domain socket patch that I kicked around on this list several weeks ago that fixed a problem where we weren't always setting a UNIX socket's peer label correctly. This patchset still includes this fix but it also includes a number of other improvements. I'm posting these patches as an RFC for two main reasons, I haven't had a chance to give them the testing I want (they boot and there are no obvious regressions in light usage) and they are based of Linus' tree and not security-testing (I will fix that before submission). However, if you want to give the patches a shot or even just review them I would appreciate any feedback you care to send along.

For those of you who like to get your patches via git, this patchset can also be found at the URL below:

* git://git.infradead.org/users/pcmoore/lblnet-2.6_testing

---

Paul Moore (6):
selinux: Update socket's label alongside inode's label
selinux: Set the peer label correctly on connected UNIX domain sockets
selinux: Consolidate sockcreate_sid logic
selinux: Shuffle the sk_security_struct alloc and free routines
selinux: Convert socket related access controls to use socket labels
selinux: Use current_security() when possible

 security/selinux/hooks.c            |  282 ++++++++++++++++-------------------
 security/selinux/include/netlabel.h |    5 -
 security/selinux/netlabel.c         |    8 +
 3 files changed, 139 insertions(+), 156 deletions(-)

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.