Skip to content

infrastructure for sparse checks for RCU usage

Paul E. McKenney lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23rcu: add an rcu_dereference_index_check()include/linux/rcupdate.h+33 -00 replies
2/23rcu: add __rcu API for later sparse checkinginclude/linux/compiler.h+2 -02 replies
3/23vfs: add fs.h to define struct fileinclude/linux/fdtable.h+1 -00 replies
4/23net: Make accesses to ->br_port safe for sparse RCUinclude/linux/if_bridge.h net/bridge/br_fdb.c net/bridge/br_private.h +5 more+21 -104 replies
5/23mce: convert to rcu_dereference_index_check()arch/x86/kernel/cpu/mcheck/mce.c+1 -10 replies
6/23rcu: define __rcu address space modifier for sparseinclude/linux/compiler.h include/linux/rcupdate.h include/linux/srcu.h +2 more+257 -1450 replies
7/23rculist: avoid __rcu annotationsinclude/linux/rculist.h include/linux/rculist_nulls.h kernel/pid.c+46 -250 replies
8/23cgroups: __rcu annotationsinclude/linux/cgroup.h include/linux/sched.h kernel/cgroup.c+4 -40 replies
9/23credentials: rcu annotationinclude/linux/sched.h+2 -21 reply
10/23keys: __rcu annotationsinclude/linux/cred.h include/linux/key.h+3 -21 reply
11/23nfs: __rcu annotationsinclude/linux/nfs_fs.h include/linux/sunrpc/auth_gss.h+3 -30 replies
12/23net: __rcu annotations for driversdrivers/net/bnx2.h drivers/net/bnx2x.h drivers/net/cnic.h +2 more+5 -50 replies
13/23perf_event: __rcu annotationsinclude/linux/perf_event.h include/linux/sched.h+4 -40 replies
14/23notifiers: __rcu annotationsinclude/linux/notifier.h+5 -50 replies
15/23radix-tree: __rcu annotationsinclude/linux/radix-tree.h lib/radix-tree.c+4 -20 replies
16/23idr: __rcu annotationsinclude/linux/idr.h+2 -20 replies
17/23input: __rcu annotationsdrivers/input/evdev.c include/linux/input.h+2 -21 reply
18/23net/netfilter: __rcu annotationsinclude/net/netfilter/nf_conntrack.h net/ipv4/netfilter/nf_nat_core.c net/netfilter/core.c +5 more+10 -101 reply
19/23kvm: add __rcu annotationsinclude/linux/kvm_host.h+1 -10 replies
20/23kernel: __rcu annotationsinclude/linux/fdtable.h include/linux/fs.h include/linux/genhd.h +3 more+11 -110 replies
21/23net: __rcu annotationsinclude/linux/igmp.h include/linux/netdevice.h include/net/dst.h +26 more+60 -590 replies
22/23kvm: more __rcu annotationsarch/x86/include/asm/kvm_host.h include/linux/kvm_host.h+3 -30 replies
23/23vhost: add __rcu annotationsdrivers/vhost/net.c drivers/vhost/vhost.c drivers/vhost/vhost.h+18 -1121 replies

Reviews trailers per patch

5 of 23 patches have a Reviewed-by or Acked-by.

PatchPaul MenageDmitry TorokhovDavid HowellsPatrick McHardy
1/23
2/23
3/23
4/23
5/23
6/23
7/23
8/23A-b
9/23A-b
10/23A-b
11/23
12/23
13/23
14/23
15/23
16/23
17/23A-b
18/23A-b
19/23
20/23
21/23
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH tip/core/rcu 0/23] infrastructure for sparse checks for RCU usage

Hello!

This patchset pulls Arnd's sparse-checking commits out of the earlier patchbomb (http://lkml.org/lkml/2010/5/4/298):

1. Add an rcu_dereference_check() API in order to continue supporting
the array-index use cases that would otherwise be invalidated by this change.
2. Add an empty __rcu annotation API to reduce inter-commit dependency.
3-5. Updates to vfs, net, and mce to avoid breakage by later commits.
6. Introduce sparse __rcu functionality.
7. Update rculist primitives to avoid false positives.
8-22. Introduce __rcu annotations to cgroups, credentials, keys, nfs,
net, perf_event, notifiers, radix-tree, idr, input, net-netfilter, kvm, and kernel.
23. Introduce __rcu annotations and checks to vhost.

These have been reordered and consolidated to reduce inter-commit dependencies.

Thanx, Paul

 b/arch/x86/include/asm/kvm_host.h      |    2 
 b/arch/x86/kernel/cpu/mcheck/mce.c     |    2 
 b/drivers/input/evdev.c                |    2 
 b/drivers/net/bnx2.h                   |    2 
 b/drivers/net/bnx2x.h                  |    2 
 b/drivers/net/cnic.h                   |    2 
 b/drivers/net/macvtap.c                |    2 
 b/drivers/vhost/net.c                  |   11 -
 b/drivers/vhost/vhost.c                |   14 -
 b/drivers/vhost/vhost.h                |    4 
 b/include/linux/cgroup.h               |    4 
 b/include/linux/compiler.h             |    2 
 b/include/linux/cred.h                 |    2 
 b/include/linux/fdtable.h              |    1 
 b/include/linux/fs.h                   |    2 
 b/include/linux/genhd.h                |    6 
 b/include/linux/idr.h                  |    4 
 b/include/linux/if_bridge.h            |    3 
 b/include/linux/if_macvlan.h           |    2 
 b/include/linux/igmp.h                 |    4 
 b/include/linux/init_task.h            |    4 
 b/include/linux/input.h                |    2 
 b/include/linux/iocontext.h            |    2 
 b/include/linux/key.h                  |    3 
 b/include/linux/kvm_host.h             |    2 
 b/include/linux/mm_types.h             |    2 
 b/include/linux/netdevice.h            |   12 -
 b/include/linux/nfs_fs.h               |    2 
 b/include/linux/notifier.h             |   10 
 b/include/linux/perf_event.h           |    6 
 b/include/linux/radix-tree.h           |    4 
 b/include/linux/rculist.h              |   53 +++-
 b/include/linux/rculist_nulls.h        |   16 +
 b/include/linux/rcupdate.h             |   33 +++
 b/include/linux/sched.h                |    2 
 b/include/linux/srcu.h                 |   27 ++
 b/include/linux/sunrpc/auth_gss.h      |    4 
 b/include/net/dst.h                    |    2 
 b/include/net/fib_rules.h              |    2 
 b/include/net/garp.h                   |    2 
 b/include/net/inet_sock.h              |    2 
 b/include/net/ip6_tunnel.h             |    2 
 b/include/net/ipip.h                   |    6 
 b/include/net/net_namespace.h          |    2 
 b/include/net/netfilter/nf_conntrack.h |    2 
 b/include/net/netns/xfrm.h             |    2 
 b/include/net/sock.h                   |    4 
 b/kernel/cgroup.c                      |    2 
 b/kernel/pid.c                         |    2 
 b/kernel/rcupdate.c                    |    6 
 b/kernel/sched.c                       |    2 
 b/lib/Kconfig.debug                    |   13 +
 b/lib/radix-tree.c                     |    2 
 b/net/802/stp.c                        |    4 
 b/net/bridge/br_fdb.c                  |    2 
 b/net/bridge/br_private.h              |    8 
 b/net/bridge/netfilter/ebt_redirect.c  |    2 
 b/net/bridge/netfilter/ebt_ulog.c      |    4 
 b/net/bridge/netfilter/ebtables.c      |    4 
 b/net/ipv4/ip_gre.c                    |    2 
 b/net/ipv4/ipip.c                      |   10 
 b/net/ipv4/netfilter/nf_nat_core.c     |    2 
 b/net/ipv4/protocol.c                  |    2 
 b/net/ipv4/route.c                     |    2 
 b/net/ipv4/tcp.c                       |    4 
 b/net/ipv6/ip6_tunnel.c                |    6 
 b/net/ipv6/protocol.c                  |    2 
 b/net/ipv6/sit.c                       |   10 
 b/net/mac80211/ieee80211_i.h           |   15 -
 b/net/mac80211/sta_info.h              |    4 
 b/net/netfilter/core.c                 |    2 
 b/net/netfilter/nf_conntrack_ecache.c  |    4 
 b/net/netfilter/nf_conntrack_extend.c  |    2 
 b/net/netfilter/nf_conntrack_proto.c   |    4 
 b/net/netfilter/nf_log.c               |    2 
 b/net/netfilter/nf_queue.c             |    2 
 b/net/netfilter/nfnetlink_log.c        |    4 
 b/net/netfilter/nfnetlink_queue.c      |    4 
 b/net/netlabel/netlabel_domainhash.c   |    4 
 b/net/netlabel/netlabel_unlabeled.c    |    4 
 b/net/netlink/af_netlink.c             |    2 
 b/net/phonet/af_phonet.c               |    2 
 b/net/phonet/pn_dev.c                  |    2 
 b/net/socket.c                         |    2 
 include/linux/compiler.h               |    4 
 include/linux/fdtable.h                |    6 
 include/linux/kvm_host.h               |    4 
 include/linux/rcupdate.h               |  352 +++++++++++++++++++--------------
 include/linux/sched.h                  |    6 
 89 files changed, 498 insertions(+), 307 deletions(-)