Skip to content

tracing/sched: Fix task states in sched_switch event

Carsten Emde lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1fix-task-states-in-sched_switch-event.patchfs/proc/array.c include/linux/sched.h include/trace/events/sched.h+69 -244 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] tracing/sched: Fix task states in sched_switch event

Hi Ingo,

Quoted 6 lines

The whole enumeration there is pointless in that .c file - it tells nothing to the code reader.

If it cannot be expressed in a meaningful way then introduce TASK_STATE_STRINGS_INIT construct that is defined next to the strings (in a .h file or so) - that way it's a coherent whole.

The updated patch
- has all definitions at a common place,
- adapts the related comment,
- makes the string array declaration in fs/proc/array.c a one-liner.

Carsten.