omap: mailbox: reorganize init
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest0 of 17 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 17 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 00/17] omap: mailbox: reorganize init
Quoted 33 lines · Felipe Contreras
Quoted 12 lines · Hiroshi DOYU
From: ext Felipe Contreras <[email protected]>
Subject: Re: [PATCH v2 00/17] omap: mailbox: reorganize init
Date: Tue, 18 May 2010 18:57:55 +0200Quoted 8 lines · Hiroshi DOYU
Quoted 7 lines
From: ext Felipe Contreras <[email protected]>
Quoted 5 lines
I'm not familiar with this kind of module loading, but certainly not all systems have udev.
I realized the problem because I have a bare-bones system in my beagleboard where I had to manually load
mailbox_mach.Quoted 6 lines
Quoted 4 lines
Quoted 1 line
With udev or something equivalent, it should work fine.
But still, you are relying on udev. I don't think we should, and I don't think there's any need.
Some expert may give some comment here.....
Russell, Tony: should
mailbox_mach, a module that checks for logical devices be always built-in?I think that's the easiest... in my patches I moved the architecture-specific code from
mach-omapX/devices.ctomach-omapX/mailbox.c, so both the logical devices and real platform devices are in the same code, and can be built-in.This way, there's no need to rely on services like udev to load mailbox, then
mailbox_mach, then bridgedriver. After all, allmailbox_machis doing is calling functions in mailbox to register the logical devices.
Quoted 4 lines
Judging from:
http://article.gmane.org/gmane.linux.ports.arm.kernel/58555The answer is yes.
Maybe try using the tested good old criteria: What works the best for "standard Linux behaviour" out of the box? :)
Anything that registers platform devices should be built in. Also anything that's needed to boot the device into a sane operating mode should be built in. For example, the DSP should be powered down (or idled on some earlier omaps) even if no bridge is being used.
Cheers,
Tony