(Was: ptrace: unify FDPIC implementations)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | ptrace: PTRACE_GETFDPIC: fix the unsafe usage of child->mmkernel/ | +8 | 18 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Roland McGrath | David Howells |
|---|---|---|
| 1/1 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH -mm 0/1] (Was: ptrace: unify FDPIC implementations)
Quoted 9 lines · Roland McGrath
Quoted 6 lines
This looks unsafe. What protect
child->mmifptrace()races with SIGKILL ?Of course, I do not blame this patch, the code was copied from
arch/, but I think we need another patch which checks ->mm != NULL undertask_lock()on top of this one?Agreed, unless things are somehow different on nommu so there aren't such races.
I don't this !CONFG_MMU can make any difference, nothing can protect us from exit_mm() afaics.
Quoted 2 lines
But, as you mention, this is a long-standing issue that is entirely unrelated to the cleanup here and should not delay merging this patch.
Yes, yes, agreed.
Please see the patch on top of ptrace-unify-fdpic-implementations.patch Untested, but hopefully trivial enough.
Oleg.