Skip to content

S390-HWBKPT v5: Hardware breakpoint implementation for

Mahesh Salgaonkar linux-s390 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Change in v5 from the cover letter

- Use exclude_kernel attribute set to decide whether to install wide breakpoint in kernel or not. This flag will be used by ptrace breakpoint.
- Removed 'info->name' field as Name to address resolving is done in generic code.
- Select CONFIG_HAVE_MIXED_BREAKPOINTS_REGS as s390 uses same register for instruction as well as data breakpoint.
- Re-based the patches on commit d67f088e084755bdceb4f15bc6e05e309db1eea7 of -tip perf/core

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3S390-HWBKPT v5: S390 architecture specific Hardwarearch/s390/Kconfig arch/s390/include/asm/Kbuild arch/s390/include/asm/hw_breakpoint.h +4 more+387 -20 replies
2/3S390-HWBKPT v5: Enabling s390 kernel for kernel PERarch/s390/include/asm/lowcore.h arch/s390/kernel/asm-offsets.c arch/s390/kernel/entry.S +2 more+55 -91 reply
3/3S390-HWBKPT v5: Modify ptrace to use Hardwarearch/s390/include/asm/ptrace.h arch/s390/kernel/process.c arch/s390/kernel/ptrace.c+155 -691 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/3] S390-HWBKPT v5: Hardware breakpoint implementation for

Hi Heiko/Frederic,

Please find the latest set of patches that introduces s390 specific implementation for perf-events based hardware breakpoint interfaces for review.

Change in v5:
- Use exclude_kernel attribute set to decide whether to install wide breakpoint in kernel or not. This flag will be used by ptrace breakpoint.
- Removed 'info->name' field as Name to address resolving is done in generic code.
- Select CONFIG_HAVE_MIXED_BREAKPOINTS_REGS as s390 uses same register for instruction as well as data breakpoint.
- Re-based the patches on commit d67f088e084755bdceb4f15bc6e05e309db1eea7 of -tip perf/core

Change in v4:
- Introduced a kernel per tracing flag in lowcore structure for each cpu instead of global.
- Handled a race condition with interrupts/preemption while looking for PER event in hw_breakpoint_handler() routine.

Change in v3:
- Merged first two patches of v1 patchset.
- Introduced second patch that implements kernel part PER tracing.

The patch set has been tested with ksym_tracer and watchpoints over GDB+ptrace and works fine.

Thanks,
-Mahesh.

Signature · 1 line
Signed-off-by: Mahesh Salgaonkar <[email protected]>