Skip to content

blackfin: ptrace mm/sram_list fixes

Oleg Nesterov linux-sh lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2blackfin: ptrace: fix the unsafe usage of mm/find_vma in is_user_addr_valid()arch/blackfin/kernel/ptrace.c+19 -80 replies
2/2blackfin: use ->mmap_sem to protect mm_context_t->sram_listarch/blackfin/mm/sram-alloc.c+16 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] blackfin: ptrace mm/sram_list fixes
Quoted 9 lines · Oleg Nesterov
Quoted 3 lines · Mike Frysinger

we probably should add proper locking to this
structure though.

Agreed. I'll try to make the trivial patch tomorrow. I think we can just use mm->mmap_sem, is_user_addr_valid() needs this lock for find_vma() anyway.

please see the patches.

UNTESTED! the second one certainly needs the review from someone who knows what this code does ;)

BTW. Obviously sys_sram_alloc() can create multiple sram_list_struct nodes with the same ->addr (with or without this patch), I hope this is fine.

Oleg.