blackfin: ptrace mm/sram_list fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | blackfin: ptrace: fix the unsafe usage of mm/find_vma in is_user_addr_valid()arch/ | +19 | 0 replies | |
| 2/2 | blackfin: use ->mmap_sem to protect mm_context_t->sram_listarch/ | +16 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] blackfin: ptrace mm/sram_list fixes
Quoted 9 lines · Oleg Nesterov
Quoted 3 lines · Mike Frysinger
we probably should add proper locking to this
structure though.Agreed. I'll try to make the trivial patch tomorrow. I think we can just use
mm->mmap_sem,is_user_addr_valid()needs this lock forfind_vma()anyway.
please see the patches.
UNTESTED! the second one certainly needs the review from someone who knows what this code does ;)
BTW. Obviously sys_sram_alloc() can create multiple sram_list_struct nodes with the same ->addr (with or without this patch), I hope this is fine.
Oleg.