Skip to content

omap: mailbox: bunch of cleanups

Tony Lindgren linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest0 of 14 patches 0 repliesNew

Patches in v3 No applies recorded yet

None of the 14 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/14] omap: mailbox: bunch of cleanups
Quoted 29 lines · Felipe Contreras
Quoted 11 lines · Russell King - ARM Linux
Quoted 3 lines · Hiroshi DOYU
Quoted 3 lines

Felipe Contreras (14):
? omap: mailbox: trivial whitespace cleanups
? omap: mailbox: trivial cleanups

I think folk need to read this:

? ? ? ?http://lkml.org/lkml/2010/6/2/472

and consider what it means for the future, and what can be done to reduce the amount of "churn".

If I have to decipher that rant, my best guess is that he is complaining about the amount of code. If that's the case, this patch series is only doing good:

6 files changed, 168 insertions(+), 230 deletions(-)

Another part of the rant is the fact that Linus cannot follow the huge amount of changes. I think "trivial whitespace cleanups" pretty much
says: don't look at me if you want to be productive, while "trivial cleanups" says, look at me if you feel like looking at easy changes. If I were to squash these two, I think the patch series would become harder to follow.

Something that helps in other projects, like git, is that merges are clearly identified.

Quoted 8 lines

Merge branch 'linux-arm'
Merge branch 'linux-omap'
Merge branch 'linux-omap-mbox'
Merge branch 'fc-cleanups'
Merge branch 'ob-kfifo'

Then it's a bit clearer what each patch series is doing in the mailbox tree without looking at individual patches.

Also we need to make sure all the code we merge is really tested well before the merge window. Too much of the code needs to be fixed after the merge window. For the upcoming merge window, we will only merge things that have been sitting in the for-next for days before the merge window opens.

Tony