Skip to content

x86: clear XD_DISABLED flag on Intel to regain NX

Kees Cook lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 3 repliesIn review
  2. v44 patches 0 repliesSuperseded
  3. v34 patches 25 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches5 repliesSuperseded
v11 patch3 repliesSuperseded

Changelog from the cover letter

v2 - rearranged use of verify_cpu()
v3 - resent, show stats on systems that need it
v4 - expanded commit messages, added acks
v5 - added acks

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86: rename verify_cpu_64.S to verify_cpu.Sarch/x86/boot/compressed/head_64.S arch/x86/kernel/trampoline_64.S arch/x86/kernel/verify_cpu.S+2 -20 replies
2/4x86: clear XD_DISABLED flag on Intel to regain NXarch/x86/kernel/verify_cpu.S+40 -82 replies
3/4x86: call verify_cpu during 32bit CPU startuparch/x86/kernel/head_32.S arch/x86/kernel/verify_cpu.S+7 -01 reply
4/4x86: only CPU features determine NX capabilitiesarch/x86/mm/setup_nx.c+1 -10 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPekka EnbergAlan Cox
1/4A-b A-b
2/4A-b A-b
3/4A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Security] [PATCH v5 0/4] x86: clear XD_DISABLED flag on Intel to regain NX

Resending with Alan Cox's Acks, at Ingo's request.

Intel CPUs have an additional MSR bit to indicate if the BIOS was configured to disable NX. This bit was traditionally used for operating systems that did not understand how to handle the NX bit. Since Linux understands this, this BIOS flag should be ignored by default.

In a review[1] of reported hardware being used by Ubuntu bug reporters, almost 10% of systems had an incorrectly configured BIOS, leaving their systems unable to use the NX features of their CPU.

This change will clear the MSR_IA32_MISC_ENABLE_XD_DISABLE bit so that NX cannot be inappropriately controlled by the BIOS on Intel CPUs. If, under very strange hardware configurations, NX actually needs to be disabled, "noexec=off" can be used to restore the prior behavior.

-Kees

[1] http://www.outflux.net/blog/archives/2010/02/18/data-mining-for-nx-bit/

---
Changelog:
v2 - rearranged use of verify_cpu()
v3 - resent, show stats on systems that need it
v4 - expanded commit messages, added acks
v5 - added acks