pid_ns_prepare_proc/unshare cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | procfs: proc_get_sb: consolidate/cleanup root_inode->pid logicfs/ | +7 | 0 replies | |
| 2/4 | procfs: kill the global proc_mnt variablefs/ fs/ fs/ | +3 | 0 replies | |
| 3/4 | procfs: move pid_ns_prepare_proc() from copy_process() to create_pid_namespace()kernel/ kernel/ | +9 | 0 replies | |
| 4/4 | sys_unshare: simplify the not-really-implemented CLONE_THREAD/SIGHAND/VM codekernel/ | +25 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Roland McGrath | Sukadev Bhattiprolu |
|---|---|---|
| Series | R-b | |
| 1/4 | ||
| 2/4 | ||
| 3/4 | ||
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] pid_ns_prepare_proc/unshare cleanups
Quoted 2 lines · Oleg Nesterov
I only try to discuss the idea to break the circular reference.
I don't know what I have missed, but this looks really right to me. Besides, we have yet another problem: proc_flush_task()->mntput() is just wrong. Consider the multithreaded execing init.
I am going to simplify, test, and send the fix which moves mntput() into free_pid_ns() paths.
But first of all I think we should cleanup the pid_ns_prepare_proc() logic. Imho, this code is really ugly. Please see the patches.
The last one, 4/4, is orthogonal to other changes.
Oleg.