Skip to content

cciss updates July 19, 2010

Stephen M. Cameron lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26cciss: Set the performant mode bit in the scsi half of the driverdrivers/block/cciss_scsi.c+2 -180 replies
2/26cciss: save pdev pointer in per hba structure early to avoid passing it around so much.drivers/block/cciss.c+31 -300 replies
3/26cciss: factor out cciss_lookup_board_iddrivers/block/cciss.c+35 -310 replies
4/26cciss: factor out cciss_board_disableddrivers/block/cciss.c+9 -60 replies
5/26cciss: remove board_id parameter from cciss_interrupt_mode()drivers/block/cciss.c+5 -60 replies
6/26cciss: factor out cciss_find_memory_BAR()drivers/block/cciss.c+19 -180 replies
7/26cciss: factor out cciss_wait_for_board_ready()drivers/block/cciss.c drivers/block/cciss.h+32 -150 replies
8/26cciss: factor out cciss_find_cfgtablesdrivers/block/cciss.c+34 -340 replies
9/26cciss: fix leak of ioremapped memorydrivers/block/cciss.c+12 -00 replies
10/26cciss: factor out cciss_find_board_paramsdrivers/block/cciss.c+25 -270 replies
11/26cciss: factor out CISS_signature_present()drivers/block/cciss.c+13 -50 replies
12/26cciss: factor out cciss_enable_scsi_prefetch()drivers/block/cciss.c+13 -100 replies
13/26cciss: factor out cciss_p600_dma_prefetch_quirk()drivers/block/cciss.c+19 -180 replies
14/26cciss: cleanup some debug ifdefsdrivers/block/cciss.c+3 -70 replies
15/26cciss: make cciss_put_controller_into_performant_mode as __devinitdrivers/block/cciss.c+1 -20 replies
16/26cciss: factor out cciss_wait_for_mode_change_ack()drivers/block/cciss.c+15 -120 replies
17/26cciss: factor out cciss_enter_performant_modedrivers/block/cciss.c+59 -390 replies
18/26cciss: factor out cciss_find_cfg_addrs.drivers/block/cciss.c+23 -120 replies
19/26cciss: factor out cciss_reset_devices()drivers/block/cciss.c drivers/block/cciss.h+34 -200 replies
20/26cciss: fix hard reset code.drivers/block/cciss.c drivers/block/cciss_cmd.h+152 -520 replies
21/26cciss: sanitize max commandsdrivers/block/cciss.c+13 -10 replies
22/26cciss: forbid hard reset of 640x boardsdrivers/block/cciss.c+16 -10 replies
23/26cciss: use consistent variable namesdrivers/block/cciss.c drivers/block/cciss.h drivers/block/cciss_scsi.c+592 -6120 replies
24/26cciss: separate cmd_alloc() and cmd_special_alloc()drivers/block/cciss.c drivers/block/cciss_scsi.c+89 -740 replies
25/26cciss: change printks to dev_warn, etc.drivers/block/cciss.c drivers/block/cciss_scsi.c+212 -2610 replies
26/26cciss: cleanup interrupt_not_for_usdrivers/block/cciss.c+1 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/26] cciss updates July 19, 2010

The following series implements mostly cleanups to the initialization code in cciss along the same lines as what's already been done in hpsa.

There are also a few bug fixes. The SCSI tape code was not setting the performant mode bits in commands, which caused a hang. The code to reset controllers via PCI power management methods only works on old controllers, so an alternate method is used for newer controllers.

There are a couple of big patches to make cciss use more consistent variable names (always h for hba, and c for command, rather than a mishmash of various things names) and to generally use dev_warn, etc. instead of printk.

These patches apply to the 'for-2.6.36' branch of Jens Axboe's git
tree: http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=summary
(there are many changes to cciss in that tree on which these patches depend.)

---

Stephen M. Cameron (26):
cciss: Set the performant mode bit in the scsi half of the driver
cciss: save pdev pointer in per hba structure early to avoid passing it around so much.
cciss: factor out cciss_lookup_board_id
cciss: factor out cciss_board_disabled
cciss: remove board_id parameter from cciss_interrupt_mode()
cciss: factor out cciss_find_memory_BAR()
cciss: factor out cciss_wait_for_board_ready()
cciss: factor out cciss_find_cfgtables
cciss: fix leak of ioremapped memory
cciss: factor out cciss_find_board_params
cciss: factor out CISS_signature_present()
cciss: factor out cciss_enable_scsi_prefetch()
cciss: factor out cciss_p600_dma_prefetch_quirk()
cciss: cleanup some debug ifdefs
cciss: make cciss_put_controller_into_performant_mode as __devinit
cciss: factor out cciss_wait_for_mode_change_ack()
cciss: factor out cciss_enter_performant_mode
cciss: factor out cciss_find_cfg_addrs.
cciss: factor out cciss_reset_devices()
cciss: fix hard reset code.
cciss: sanitize max commands
cciss: forbid hard reset of 640x boards
cciss: use consistent variable names
cciss: separate cmd_alloc() and cmd_special_alloc()
cciss: change printks to dev_warn, etc.
cciss: cleanup interrupt_not_for_us

 drivers/block/cciss.c      | 1728 ++++++++++++++++++++++++--------------------
 drivers/block/cciss.h      |   20 -
 drivers/block/cciss_cmd.h  |    4 
 drivers/block/cciss_scsi.c |  666 ++++++++---------
 4 files changed, 1276 insertions(+), 1142 deletions(-)
Signature · 1 line
-- steve