Skip to content

padata/pcrypt: fixes

Steffen Klassert linux-crypto lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4padata: Fix cpu index countingkernel/padata.c+1 -00 replies
2/4padata: Allocate cpumask dependend recources in any casekernel/padata.c+7 -170 replies
3/4padata: Check for valid cpumaskskernel/padata.c+1 -10 replies
4/4crypto: pcrypt - Dont calulate a callback cpu on empty callback cpumaskcrypto/pcrypt.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] padata/pcrypt: fixes

This patchset contains the following fixes:

1. padata - Fix a potential hang of the parallel worker threads on cpu hotplug.

2. padata - Fix two NULL pointer dereference crashes if one of the padata cpumasks is empty. The crashes can be triggered by doing echo 0 > /sys/kernel/pcrypt/pencrypt/[parallel_cpumask/serial_cpumask]

3. padata - Fix a division by zero crash if the parallel cpumask contains no active cpu. Can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask

4. pcrypt - Fix division by zero crash if the callback cpumask is empty. Can be triggered by doing
echo 0 > /sys/kernel/pcrypt/pencrypt/serial_cpumask

I ran a script that does cpumask changes and cpu hotplugs as fast as possible while sending IPsec packets on maximal rate with pcrypt. It showed no furter crashes overnight, so I hope I've got them all.

padata API corrections and some minor fixes/cleanups are comming later.

Steffen