IB/srp: Add SRP_CRED_REQ and SRP_AER_REQ support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 13 repliesIn review
- v43 patches 9 repliesSuperseded
- v34 patches 3 repliesApplied
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 15 replies | Superseded |
Changes in v5 compared to v4 from the cover letter
- Added support for processing the SRP_AER_REQ information unit.
- Introduced a new symbolic name, SRP_NORMAL_REQ_SQ_SIZE, that represents the maximum number of requests that may be queued by the SCSI mid-layer.
- Changed transmit ring overflow check back to that of v3 (removed "- rsv" again).
- Reduced the size of the srp_target_port.req_ring array by one element such that its size again matches the maximum number of requests that can be queued by the SCSI mid-layer.
- Moved BUILD_BUG_ON_NOT_POWER_OF_2() statements to the module initialization function.
- Updated patch descriptions.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | IB/srp: Preparation for transmit ring response allocationdrivers/ drivers/ | +28 | 8 replies | |
| 2/3 | IB/srp: Implement SRP_CRED_REQ and SRP_AER_REQdrivers/ drivers/ include/ | +225 | 4 replies | |
| 3/3 | IB/srp: Reduce number of BUSY conditionsdrivers/ | +7 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH 0/3 v5] IB/srp: Add SRP_CRED_REQ and SRP_AER_REQ support
This series of three patches adds SRP_CRED_REQ ans SRP_AER_REQ support in ib_srp. Both are information units defined in the SRP (draft) standard.
Changes in v5 compared to v4:
- Added support for processing the SRP_AER_REQ information unit.
- Introduced a new symbolic name, SRP_NORMAL_REQ_SQ_SIZE, that represents the maximum number of requests that may be queued by the SCSI mid-layer.
- Changed transmit ring overflow check back to that of v3 (removed "- rsv" again).
- Reduced the size of the srp_target_port.req_ring array by one element such that its size again matches the maximum number of requests that can be queued by the SCSI mid-layer.
- Moved BUILD_BUG_ON_NOT_POWER_OF_2() statements to the module initialization function.
- Updated patch descriptions.
Changes in v4 compared to v3:
- Dropped the fourth patch since it has been merged.
- Introduced the symbolic constant SRP_TSK_MGMT_RSV, which represents the number of slots reserved in the tx ring for SRP task management requests.
- One slot of the transmit ring buffer is now reserved for sending SRP_TSK_MGMT requests.
- The BUILD_BUG_ON_NOT_POWER_OF_2() macro is now used to verify whether SRP_RQ_MASK and SRP_SQ_MASK really are bitmasks.
- Rearranged function order such that no new forward declarations have to be introduced in the second patch.
- Eliminated the srp_target_port.tx_req and tx_rsp variables.
- Removed the SRP_OP_RSP flag.
- Added a source code comment that explains why can_queue must be less than req_lim.
Changes in v3 compared to v2:
- Corrected completion queue size from SRP_REQ_SQ_SIZE (63) into SRP_SQ_SIZE (64).
- Merged the two functions __srp_get_tx_req_iu() and __srp_get_tx_rsp_iu() into a single function __srp_get_tx_iu().
- Removed __attribute__((packed)) from the structure definitions added in include/scsi/srp.h because it was superfluous.
- Modified descriptions of patches 1/4, 2/4 and 3/4.
Changes in v2 compared to v1:
- Split the big patch into multiple patches, which makes reviewing easier.
- Instead of defining separate queues for transmitting requests and responses, a single queue is now used.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html