Skip to content

Use monotonic time stamps in sunrpc auth cache.

NeilBrown linux-nfs 1 version Applied

Status from this message: Merged into the previous patch (not pushed out yet pending some

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2sunrpc: extract some common sunrpc_cache code from nfsdfs/nfsd/export.c include/linux/sunrpc/cache.h+9 -61 reply
2/2sunrpc: use monotonic time in expiry cachefs/nfs/dns_resolve.c fs/nfsd/nfs4idmap.c include/linux/sunrpc/cache.h +1 more+42 -243 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Use monotonic time stamps in sunrpc auth cache.

A 6 month release cycles seems to be popular these days, and it is six months since I last posted these, so I guess it is time to post them again (yes, I've been busy and forgot all about them - but I still think they are important).

If you set your system time backwards, nfsd can end up caching things much longer than it should. And if you set if very far forward, caches will get flushed too early.

So change all time keeping to use a monotonic time based on getboottime.

A few issues were raised last time I posted these:
http://www.spinics.net/lists/linux-nfs/msg11515.html
I think they have all been addressed now.

Thanks,
NeilBrown

---

NeilBrown (2):
sunrpc: extract some common sunrpc_cache code from nfsd
sunrpc: use monotonic time in expiry cache

 fs/nfs/dns_resolve.c         |    6 +++---
 fs/nfsd/export.c             |    9 +++------
 fs/nfsd/nfs4idmap.c          |    2 +-
 include/linux/sunrpc/cache.h |   23 ++++++++++++++++++++++-
 net/sunrpc/cache.c           |   37 ++++++++++++++++++++-----------------
 5 files changed, 49 insertions(+), 28 deletions(-)