Skip to content

virtio-net: More configurability and bh handling for tx

Alex Williamson kvm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v15 patches 17 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4virtio-net: Make tx_timer timeout configurablehw/s390-virtio-bus.c hw/s390-virtio-bus.h hw/syborg_virtio.c +4 more+27 -70 replies
2/4virtio-net: Limit number of packets sent per TX flushhw/s390-virtio-bus.c hw/syborg_virtio.c hw/virtio-net.c +2 more+29 -60 replies
3/4virtio-net: Rename tx_timer_active to tx_waitinghw/virtio-net.c+9 -90 replies
4/4virtio-net: Introduce a new bottom half packet TXhw/s390-virtio-bus.c hw/syborg_virtio.c hw/virtio-net.c +2 more+81 -80 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJuan Quintela
SeriesA-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx

Incorporated feedback. txburst= and txtimer= are now "x-" prefixed developer options. I added a tx= option, because I do want there to be a supported way to switch between TX strategies. This also drops the magic value of txtimer= 1 or 0 (setting default timeout or switching modes). I also dropped the trickiness around only enabling the bottom half for the iothread since Anthony indicates we don't care about performance for the non-iothread case.

New performance data against both qemu.git and qemu-kvm.git:

https://spreadsheets.google.com/pub?key=0AoEm50Bac2U7dGdlREhrWUpPVEdMcTJaX0RjSEgtc3c&hl=en&single=true&gid=0&output=html

This shows the base performance versus patched with new default for various packet sizes and netperf test loads. The guest is a 2-way SMP, connected directly to the host via a tap (no bridge). Thanks,

Alex

---

Alex Williamson (4):
virtio-net: Introduce a new bottom half packet TX
virtio-net: Rename tx_timer_active to tx_waiting
virtio-net: Limit number of packets sent per TX flush
virtio-net: Make tx_timer timeout configurable

 hw/s390-virtio-bus.c |    8 +++
 hw/s390-virtio-bus.h |    1 
 hw/syborg_virtio.c   |    8 +++
 hw/virtio-net.c      |  129 +++++++++++++++++++++++++++++++++++++++++---------
 hw/virtio-net.h      |   14 +++++
 hw/virtio-pci.c      |    8 +++
 hw/virtio.h          |    4 +-
 7 files changed, 144 insertions(+), 28 deletions(-)