Skip to content

add spi support for i.MX51 in the existing spi_imx driver

Uwe Kleine-König linux-arm-kernel linux-spi 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ARM: mx51: clean up mx51 headerarch/arm/plat-mxc/include/mach/mx51.h+300 -3080 replies
2/6ARM: mx51: fix naming of spi related definesarch/arm/plat-mxc/include/mach/mx51.h+6 -60 replies
3/6ARM: imx: change the way spi-imx devices are registeredarch/arm/mach-imx/devices-imx21.h arch/arm/mach-imx/devices-imx27.h arch/arm/mach-mx25/devices-imx25.h +4 more+103 -370 replies
4/6ARM: mx51: Add spi clock and spi_imx device registrationarch/arm/mach-mx5/clock-mx51.c arch/arm/mach-mx5/devices-imx51.h arch/arm/plat-mxc/devices/platform-spi_imx.c+77 -01 reply
5/6spi-imx: Add i.MX51 supportdrivers/spi/spi_imx.c+120 -31 reply
5/6spi-imx: Add i.MX51 support+0 -00 replies
6/6ARM: mx5/mx51_babbage: Add spi supportarch/arm/mach-mx5/Kconfig arch/arm/mach-mx5/board-mx51_babbage.c+32 -00 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchWolfram SangGrant Likely
SeriesA-b A-b A-b
1/6
2/6A-b
3/6A-b
4/6
5/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] add spi support for i.MX51 in the existing spi_imx driver

Hello Jason,

Quoted 12 lines · Jason Wang

Some explanations:

This patchset is to add SPI support in the existing spi_imx driver for i.MX51 and add SPI relating stuffs for mx51_3ds board level.

i.MX51 has two eCSPI controllers and one CSPI controller, CSPI controller is 100% compatible with the one of i.MX35, so we don't need to add new functions for this CSPI, only bind it with i.MX35 together, while eCSPI isn't compatible with existing controllers of i.MX platforms, so i add new functions for these two eCSPIs in the existing spi_imx driver.

Quoted 3 lines

If these patches pass review, the first patch 0001-xxx.patch should be merged by Grant.likely; other patches(0002-0006) are based off imx-for-2.6.37 and should be handled by Sascha.

Unfortunately we (=Pengutronix) have some patches pending to add mx51-spi support, too. And there are some other patches that will conflict with your series (e.g. I renamed some symbols used by you:

-#define MX51_CSPI1_BASE_ADDR (MX51_SPBA0_BASE_ADDR + 0x10000)
+#define MX51_ECSPI1_BASE_ADDR (MX51_SPBA0_BASE_ADDR + 0x10000)
-#define MX51_CSPI2_BASE_ADDR (MX51_AIPS2_BASE_ADDR + 0xac000)
+#define MX51_ECSPI2_BASE_ADDR (MX51_AIPS2_BASE_ADDR + 0xac000)
-#define MX51_CSPI3_BASE_ADDR (MX51_AIPS2_BASE_ADDR + 0xc0000)
+#define MX51_CSPI_BASE_ADDR (MX51_AIPS2_BASE_ADDR + 0xc0000)
-#define MX51_MXC_INT_CSPI1 36
-#define MX51_MXC_INT_CSPI2 37
-#define MX51_MXC_INT_CSPI 38
+#define MX51_INT_ECSPI1 36
+#define MX51_INT_ECSPI2 37
+#define MX51_INT_CSPI 38
)

Actually I would prefer our patches, but of course I'm biased :-)

I don't know how we should handle this. And Sascha is on vacation this and next week. I will investigate if our patches are already free to be posted.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |