ath: Move key cache functions to ath common
Get series with b4
b4 am 20100908070427.11255.17659.stgit@tt-deskVersions newest first
- v1 Latest8 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | ath: Copy cryptographic capability flags into athdrivers/ | +10 | 0 replies | |
| 2/8 | ath: Copy key cache management functions from ath9k to athdrivers/ drivers/ drivers/ +1 more | +620 | 0 replies | |
| 3/8 | ath5k: Use common ath key management functionsdrivers/ drivers/ | +17 | 3 replies | |
| 4/8 | ath5k: Remove old ath5k key handling functionsdrivers/ drivers/ drivers/ | +0 | 1 reply | |
| 5/8 | ath/ath9k: Replace common->splitmic with a flagdrivers/ drivers/ drivers/ +1 more | +16 | 1 reply | |
| 6/8 | ath5k: Use common crypt capabilities flagsdrivers/ drivers/ drivers/ | +7 | 3 replies | |
| 7/8 | ath9k: Use common ath key management functionsdrivers/ drivers/ drivers/ +7 more | +6 | 0 replies | |
| 8/8 | ath9k: Use common crypt capabilities flagsdrivers/ drivers/ | +23 | 0 replies |
Reviews trailers per patch
2 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Bob Copeland |
|---|---|
| 1/8 | |
| 2/8 | |
| 3/8 | |
| 4/8 | A-b |
| 5/8 | A-b |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] ath: Move key cache functions to ath common
The following series moves the key cache management functions from ath9k to the common ath/key.c so we can also use them from ath5k. Both ath5k and ath9k are changed to use the common key functions.
This is necessary since HW encryption in ath5k was broken for AP mode and software encryption was enabled as a workaround (in "ath5k: temporarily disable crypto for AP mode", 65b5a69860ed3bc4224368b804d381cd9cafa90a). Using software encryption has a performance impact, which we would like to avoid, especially on embedded boards, which is where AP configurations are most common. On embedded AP boards we definetly want to make use of the chipsets HW encryption.
The symptom of the broken HW encryption was that when two clients connected to one AP with WPA (AES or TKIP) as soon as the second client connected, the first one was not able to send or receive packets.
Rather than trying to fix the ath5k implementation, i think it makes more sense to share this code between ath5k and ath9k.
This series was tested with ath5k (AR5414) in AP and station mode and with ath9k 9160 in AP mode, both with TKIP and AES. ath9k_htc was compile tested only.
bruno
---
Bruno Randolf (8):
ath: Copy cryptographic capability flags into ath
ath: Copy key cache management functions from ath9k to ath
ath5k: Use common ath key management functions
ath5k: Remove old ath5k key handling functions ath/ath9k: Replace common->splitmic with a flag
ath5k: Use common crypt capabilities flags
ath9k: Use common ath key management functions
ath9k: Use common crypt capabilities flags
drivers/net/wireless/ath/Makefile | 3 drivers/net/wireless/ath/ath.h | 39 ++ drivers/net/wireless/ath/ath5k/ath5k.h | 7 drivers/net/wireless/ath/ath5k/attach.c | 13 - drivers/net/wireless/ath/ath5k/base.c | 35 +- drivers/net/wireless/ath/ath5k/pcu.c | 191 -------- drivers/net/wireless/ath/ath5k/reg.h | 42 -- drivers/net/wireless/ath/ath9k/common.c | 270 ------------ drivers/net/wireless/ath/ath9k/common.h | 6 drivers/net/wireless/ath/ath9k/htc_drv_init.c | 2 drivers/net/wireless/ath/ath9k/htc_drv_main.c | 4 drivers/net/wireless/ath/ath9k/hw.c | 288 ------------- drivers/net/wireless/ath/ath9k/hw.h | 46 +- drivers/net/wireless/ath/ath9k/init.c | 6 drivers/net/wireless/ath/ath9k/mac.h | 21 - drivers/net/wireless/ath/ath9k/main.c | 4 drivers/net/wireless/ath/ath9k/phy.h | 3 drivers/net/wireless/ath/key.c | 568 +++++++++++++++++++++++++ drivers/net/wireless/ath/reg.h | 23 + 19 files changed, 686 insertions(+), 885 deletions(-) create mode 100644 drivers/net/wireless/ath/key.c
--