Skip to content

IR/imon: split out mouse events and fix bugs

Jarod Wilson linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4IR: export ir_keyup so imon driver can use it directlydrivers/media/IR/ir-keytable.c include/media/ir-core.h+3 -10 replies
2/4imon: split mouse events to a separate input devdrivers/media/IR/imon.c+160 -1134 replies
3/4IR/imon: protect ictx's kc and last_keycode w/spinlockdrivers/media/IR/imon.c+46 -60 replies
4/4IR/imon: set up mce-only devices w/mce keytabledrivers/media/IR/imon.c+138 -1262 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] IR/imon: split out mouse events and fix bugs

These patches make the imon driver slightly less distasteful. The meat of the changes are from David's patch to split the IR mouse mode and panel/knob events out onto their own input device, leaving just IR keys to come through the IR device. This facilitates further abstraction of the ir/rc-core interface, but allows us to get these patches in ahead of David's major reshuffle that is targeted for post-2.6.37-rc1 (basically, after Dmitry's large keycode patches are merged in mainline).

Additionally, while David's patch unknowingly addressed many of the issues in https://bugzilla.kernel.org/show_bug.cgi?id=16351, there are a few more issues addressed by the spinlock patch (at least, in theory, since in practice, it doesn't really seem to matter much to me, but Anssi suggested that some locking may be a good idea in the bug :).

Finally, there's a bit of reshuffling of auto-config bits for the 0xffdc imon devices so the mce-only ones get set up w/the mce key table by default instead of the imon pad one (based on input from Anders Eriksson over on the lirc list).

David Härdeman (1):
imon: split mouse events to a separate input dev

Jarod Wilson (3):
IR: export ir_keyup so imon driver can use it directly IR/imon: protect ictx's kc and last_keycode w/spinlock IR/imon: set up mce-only devices w/mce keytable

 drivers/media/IR/imon.c        |  583 +++++++++++++++++++++++-----------------
 drivers/media/IR/ir-keytable.c |    3 +-
 include/media/ir-core.h        |    1 +
 3 files changed, 344 insertions(+), 243 deletions(-)
Signature · 2 lines
Jarod Wilson
[email protected]