Skip to content

ocfs2: Resolve the problem of truncate log flush.

Joel Becker ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/3] ocfs2: Resolve the problem of truncate log flush.
Quoted 6 lines · Tao Ma

0002-0003 are a little complicate here.
So in general, even we have freed the clusters to the global bitmap(by the above flush), we can't use them because they haven't been committed to the disk(check the comments above ocfs2_test_bg_bit_allocatable for details). So we have to tell jbd2 to flush immediately.

Mark,
Didn't we do something to allow our allocation to re-use these
clusters? Or was that for "thought to be allocated but never actually used" clusters?

Quoted 9 lines

0002 reverts some change in commit c271c5c so that now even in local mode we can force jbd2 to flush immediately.
0003 add the 'checkpoint' to ocfs2_truncate_log_needs_flush, so that the callers know that we need to checkpoint after the flush.

Actually 0003 can work without 0002 since in cluster env, ocfs2_start_checkpoint will work and 0002 is just used for a local mode. So feel free to drop 0002 if we decide to still keep ocfs2cmt out of local mode.

Assuming we want to force jbd2 out, which is heavy as you point
out, can't we just sync the filesystem? Wouldn't that work without adding ocfs2cmt?

Joel

Signature · 9 lines
"I am working for the time when unqualified blacks, browns, and
 women join the unqualified men in running our government."
	- Sissy Farenthold

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127