Skip to content

Adding support for esdhc on mx35/51

Wolfram Sang linux-arm-kernel linux-mmc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Adding support for esdhc on mx35/51

Hi Richard,

Quoted 3 lines

* About the share between i.MX and PPC eSDHC.
Why configure a few parts be shared between the i.MX eSDHC and PPC eSDHC? Can they be separated into two independent systems?

The rule of thumb is to avoid code-duplication. Assume the PPC driver gets fixed an off-by-one error in the freq-calculation, you surely want to have that fix on imx, too.

Quoted 2 lines

It would bring the conveniences to maintain stuff in the future if we separate them.

If you can name these conveniences and they are convincing, we can keep them seperate. At the moment, I don't see them (what doesn't mean they don't exist)

Quoted 1 line

And there is already one set of eSDHC driver for all the i.MX SOCs.

I am confused: which set do you mean?

Quoted 1 line

As we know that i.MX and PPC are the disparate SOC families.

Well, if the eSDHC-core itself is the same or very similar, that doesn't really matter IMO. Especially as the of-platform-bus might disappear somewhen in the future, the PPC and imx-drivers could become more similar.

Quoted 2 lines

* About the driver name of i.MX eSDHC driver, I think that use the imx to identify it is better than esdhc.

I picked up Anton's suggestion 'sdhci-esdhc-imx.c' so far. Although I am still not sure if 'sdhci-esdhc-pltfm.c' would be more precise.

Quoted 3 lines

As I know that the eSDHC name wouldn't be used anymore in next generation SOCs of i.MX family.
So the name of imx would be much clear and exact.

Not really, because all _existing_ implementations are called eSDHC, no? :) If some future incarnations have a different name, but behave the same or very similar, this is usually no problem. Check for example the I2C eeprom driver which is named 'at24' but support basically all EEPROMs and not only Atmel ones. Same goes for a couple of RTC-drivers, etc...

Kind regards,

Wolfram

Signature · 9 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100924/b4783607/attachment.sig>