Skip to content

arm: raw_spinlock annotations

Uwe Kleine-König linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ARM: Convert dma_spin_lock to raw_spinlockarch/arm/include/asm/dma.h arch/arm/kernel/dma.c+4 -40 replies
2/12ARM: smp: Convert stop_lock to raw_spinlockarch/arm/kernel/smp.c+3 -30 replies
3/12ARM: Convert die_lock and undef_lock to raw_spinlocksarch/arm/kernel/traps.c+10 -100 replies
4/12ARM: Convert l2x0_lock to raw_spinlockarch/arm/mm/cache-l2x0.c+17 -170 replies
5/12ARM: Convert cpu_asid_lock to raw_spinlockarch/arm/mm/context.c+4 -40 replies
6/12ARM: Convert xscale minicache_lock to raw_spinlockarch/arm/mm/copypage-xscale.c+3 -30 replies
7/12ARM: Convert v4 minicache_lock to raw_spinlockarch/arm/mm/copypage-v4mc.c+3 -30 replies
8/12ARM: Convert v6_lock to raw_spinlockarch/arm/mm/copypage-v6.c+5 -50 replies
9/12ARM: footbridge: Convert gpio and led locks to raw_spinlockarch/arm/mach-footbridge/include/mach/hardware.h arch/arm/mach-footbridge/netwinder-hw.c arch/arm/mach-footbridge/netwinder-leds.c +4 more+23 -230 replies
10/12ARM: integrator: Convert cm_lock and v3_lock to raw_spinlockarch/arm/mach-integrator/core.c arch/arm/mach-integrator/pci_v3.c+10 -100 replies
11/12ARM: ixp4xx: Convert pci_lock to raw_spinlockarch/arm/mach-ixp4xx/common-pci.c+11 -110 replies
12/12ARM: shark: Convert leds_lock to raw_spinlockarch/arm/mach-shark/leds.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 00/12] arm: raw_spinlock annotations

Hello,

Quoted 8 lines · Thomas Gleixner

Preempt-RT converts spinlocks to sleeping spinlocks, but some spinlocks need to be kept as real spinlocks. In 2.6.33 we merged the spinlock namespace cleanup which allows us to annotate those locks. The lock type is change to raw_spinlock which is the same as a common spinlock in !RT kernels.

The following series is a collection of lock annotations from the preempt-rt tree. Please merge into 2.6.34.

Back then I imported these changes in my repo and found them now when cleaning it up. I once tried to get them in[1], and Russell answered:

Thomas asked me about a pull request for his patches, and I said no because they're spread across many different mach-* directories. So this isn't helpful.

I don't understand that critism, as apart from "ARM: footbridge: Convert gpio and led locks to raw_spinlock" most patches (9) only touch a single file, the others only touch a single lock and fix all callers. The footbridge patch admittedly is not that nice, but that's because the touched lock is used all across the tree.

While cleaning up my repo I refound the patches and rebased them on top of today's Linus' tree and only needed to fix up the l2x0_lock patch as in the meantime a new usage hit mainline.

Best regards
Uwe

[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/74675

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |