Skip to content

tproxy fixes for current upstream code

KOVACS Krisztian netdev netfilter-devel 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3tproxy: kick out TIME_WAIT sockets in case a new connection comes in with the same tupleinclude/net/netfilter/nf_tproxy_core.h net/netfilter/nf_tproxy_core.c net/netfilter/xt_TPROXY.c +1 more+90 -151 reply
2/3tproxy: add lookup type checks for UDP in nf_tproxy_get_sock_v4()include/net/netfilter/nf_tproxy_core.h net/netfilter/nf_tproxy_core.c+114 -501 reply
3/3tproxy: fix hash locking issue when using port redirection in __inet_inherit_port()include/net/inet_hashtables.h net/dccp/ipv4.c net/dccp/ipv6.c +3 more+56 -161 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] tproxy fixes for current upstream code

The following series fix a handful of issues which have been found in the current upstream IPv4 tproxy code:

* an issue with how port redirection interacts with TCP TIME_WAIT sockets
* UDP socket lookup fixes so that now it prefers connected sockets, etc.
* fix for a bind hash issue which could trigger crashes when port redirection was used.

---

Balazs Scheidler (2):
tproxy: kick out TIME_WAIT sockets in case a new connection comes in with the same tuple
tproxy: add lookup type checks for UDP in nf_tproxy_get_sock_v4()

KOVACS Krisztian (1):
tproxy: fix hash locking issue when using port redirection in __inet_inherit_port()

 include/net/inet_hashtables.h          |    2 -
 include/net/netfilter/nf_tproxy_core.h |  120 +++++++++++++++++++++++++++++++-
 net/dccp/ipv4.c                        |   10 ++-
 net/dccp/ipv6.c                        |   10 ++-
 net/ipv4/inet_hashtables.c             |   28 +++++++
 net/ipv4/tcp_ipv4.c                    |   10 ++-
 net/ipv6/tcp_ipv6.c                    |   12 ++-
 net/netfilter/nf_tproxy_core.c         |   35 ---------
 net/netfilter/xt_TPROXY.c              |   68 +++++++++++++++++-
 net/netfilter/xt_socket.c              |    2 -
 10 files changed, 238 insertions(+), 59 deletions(-)
Signature · 1 line
KOVACS Krisztian