reworked minimal inode_lock breaking series
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest14 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | fs: icache begin inode_lock lock breakingfs/ | +17 | 0 replies | |
| 2/14 | fs: icache lock i_countarch/ drivers/ fs/ +57 more | +159 | 0 replies | |
| 3/14 | fs: icache lock inodes icache statefs/ fs/ fs/ +2 more | +176 | 0 replies | |
| 4/14 | fs: icache unmount code cleanupfs/ fs/ include/ | +17 | 0 replies | |
| 5/14 | fs: icache lock s_inodes listfs/ fs/ fs/ +3 more | +75 | 0 replies | |
| 6/14 | fs: icache lock inode hashfs/ | +75 | 0 replies | |
| 7/14 | fs: icache lock lru/writeback listsfs/ fs/ fs/ +2 more | +114 | 0 replies | |
| 8/14 | fs: icache make nr_inodes and nr_unused atomicfs/ fs/ include/ +1 more | +54 | 0 replies | |
| 9/14 | fs: inode atomic last_ino, iunique lockfs/ | +33 | 0 replies | |
| 10/14 | fs: icache remove inode_lockDocumentation/ Documentation/ Documentation/ +13 more | +59 | 0 replies | |
| 11/14 | fs: icache factor hash lock into functionsfs/ | +24 | 0 replies | |
| 12/14 | fs: icache lazy inode lrufs/ fs/ fs/ +43 more | +116 | 0 replies | |
| 13/14 | fs: icache split IO and LRU listsfs/ fs/ fs/ +4 more | +74 | 3 replies | |
| 14/14 | fs: icache split writeback and lru locksfs/ | +15 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [patch 00/14] reworked minimal inode_lock breaking series
I am still very much against the locking design of Dave's patchset, but especially the way it is broken out. I could fathom accepting some of the i_lock width reduction if they are properly broken out and justified and documented why they are safe. But lumping this huge series of stuff before inode_lock is even lifted is not the right way to go about it.
I still maintain that i_lock for icache state lock is the way to go at least until we get quite a way down the track. I think a lot of people can't see it maybe because my patchset wasn't broken out terribly well.
So I am posting here just the initial lock breaking part, reworked. In particular, i_lock coverage is established before adding broken out data structure locks, but it also cleans things up and attempts not to move stuff around that isn't strictly required.
I still wait until everything is covered before touching inode_lock, but I have explained how it is actually possible to start removing some of inode_lock even before then, which I think is a good demonstration of the power of having full i_lock coverage.
The steps here should be relatively easy to follow and verify (I hope), and they lead quite easily to the actual scalability improvement steps. So please don't get sidetracked on the temporary trylock ugliness!
Thanks,
Nick