RFC omap3evm: Add support for quick boot
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest1 of 3 patches 0 repliesNew
1 of 3 patches is in this archive. The cover letter announces 3.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | omap3evm: Move generic config options in common file | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [RFC 0/3] omap3evm: Add support for quick boot
Dear Sanjeev Premi,
Quoted 5 lines · In message <[email protected]> you wrote:
This series is based on the comments received [1] on my earlier submission[2].
Intent of sending as RFC is to thrash out the ideas and then send a formal patch.
Sorry, as you submitted this I see only 3 completely new files without relation to each other nor with any relation to the existing code.
I suggest the following approach:
Patch 1: move common code out of include/configs/omap3_evm.h into a
new file include/configs/omap3_evm_common.h; this patch should result in exactly the same code for the board as we have now.
Do not rename omap3_evm.h into omap3_evm_full.h; this makes no sense to me. omap3_evm.h is and remains the default configuration.
Patch 2: Create a new file omap3_evm_quick.h, which contains the
speed optimized configuration settings. Get rid of all the #ifndef FOO #define FOO #endif stuff there. This is a plain simple and fixed configuration, so this is not needed.
You may even consider to splitting this more - into omap3_evm_quick_nand.h and omap3_evm_quick_mmc.h to eliminate even more of the #ifdeffery.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A modem is a baudy house.