Skip to content

RFC ARM Relocation Config Cleanup

Wolfgang Denk u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH RFC 0/3] ARM Relocation Config Cleanup

Dear Albert ARIBAUD,

Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 2 lines

OK, renamed into CONFIG_NEEDS_MANUAL_RELOC.

Wait... This is the other way around, isn't it? When a board defines CONFIG_RELOC_FIXUP_WORKS, it means "no need to do manual fixups", I think.

Yes, that was the case with CONFIG_RELOC_FIXUP_WORKS. but this is what we consider standard today, so we don't define this normally.

Instead, for the few architectures that need it, we define now CONFIG_NEEDS_MANUAL_RELOC.

Of course the logic of the conditions needed to be inverted, i. e. I changed

	#if !defined(CONFIG_RELOC_FIXUP_WORKS)
into
	#if defined(CONFIG_NEEDS_MANUAL_RELOC)

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The question of whether a computer can think is no more  interesting
than the question of whether a submarine can swim"
                                                - Edsgar W.  Dijkstra