Skip to content

RFC tracing: Have trace_printk()s in the events/ directory

Steven Rostedt lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracing: Rename trace_printk to ftrace_printkinclude/linux/kernel.h+7 -70 replies
2/2tracing: Make event based trace_printk()include/asm-generic/vmlinux.lds.h include/linux/kernel.h include/trace/event_printk.h +4 more+428 -25 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][PATCH 0/2] tracing: Have trace_printk()s in the events/ directory

As suggested in:

LKML-Reference: <20101116221726.GB26243@nowhere>
or
http://marc.info/?l=linux-kernel&m=128994587230629

To have trace_printks in the events directory.

This patch set just does it for ftrace, although it can also lay the ground work for both perf and trace (are they different tools?)

This patch set converts the current trace_printk() into ftrace_printk() (back to it's original name) and that stays the same.

The new trace_printk() is off by default (we can change that later with a kernel command line option perhaps), but it can be enable now with the events directory.

Each trace_printk() added will get a entry in the debugfs/tracing/events/ directory as debugfs/tracing/entry/path/to/trace_printk/

For example, I added a trace_printk() in kernel/sched.c at line 2180 and it creates:

# ls /debug/tracing/events/printk/kernel/sched.c/2180/
enable  format

The format is the printk format:

# cat /debug/tracing/events/printk/kernel/sched.c/2180/format 
"migrate task %s:%d
"

Every directory has an "enable" file. By echoing 0 or 1 into this file, it will enable all the trace_printk's below it.

This also uses jump_label() to keep overhead down when disabled.

Note, modules are not (yet) supported.

This is just the ground work. I'm busy doing other things so if you need more, feel free to take this and carry on.

-- Steve

The following patches are in:

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

branch: rfc/event-printk

Steven Rostedt (2):
tracing: Rename trace_printk to ftrace_printk
tracing: Make event based trace_printk()

----

 include/asm-generic/vmlinux.lds.h |    7 +-
 include/linux/kernel.h            |   16 +-
 include/trace/event_printk.h      |   52 ++++++
 kernel/trace/Makefile             |    1 +
 kernel/trace/event_printk.c       |  365 +++++++++++++++++++++++++++++++++++++
 kernel/trace/trace.h              |    1 +
 kernel/trace/trace_events.c       |    2 +-
 7 files changed, 435 insertions(+), 9 deletions(-)