Patches to make multi-soc handling in entry-armv.S easier
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Janusz Krzysztofik |
|---|---|
| Series | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
Quoted 18 lines · Tony Lindgren
Quoted 8 lines · Nicolas Pitre
On Sat, 4 Dec 2010, Tony Lindgren wrote:
My only problem with your approach is the global addition of
asm_irq_baseandasm_irq_flagsin generic code which might not be useful and/or appropriate for all targets. If you were confining them to some OMAP specific file then I wouldn't mind as much. Looking at the patch I see that you hadomap_irq_basebefore. Why wasn't that sufficient? Onlyomap_irq_flagswould be missing.I guess I was thinking this is something that might help others to build more machines into one defconfig. If that's not the case, sure these can be kept omap specific.
After a quick browsing of the
entry-macro.Sfiles, looks like there's some similar ifdeffery for get_irqnr_* macros that just might be possible to clear out withasm_irq_baseandasm_irq_flags:
Quoted 8 lines
arch/arm/mach-davinci/include/mach/entry-macro.Sarch/arm/mach-s5p64x0/include/mach/entry-macro.Sarch/arm/mach-ixp4xx/include/mach/entry-macro.Sarch/arm/mach-h720x/include/mach/entry-macro.Sarch/arm/plat-mxc/include/mach/entry-macro.SMaybe let's wait a while to see if there are other use cases, if not, I'll make them omap specific.
OK, no other people interested, will post the omap specific versions as a reply to this message.
Regards,
Tony