Skip to content

RFC Non disruptive application core dump infrastructure

Suzuki K. Poulose lkml 1 version In review

Get series with b4
b4 am 20101214152259.67896960@suzukikp

Versions newest first

  1. v1 RFC Latest21 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21Reuse freezable() predicateinclude/linux/freezer.h kernel/power/process.c+12 -90 replies
2/21Create elfcore-common.c for ELF class independent core generation helpersfs/Makefile fs/binfmt_elf.c fs/elfcore-common.c +1 more+177 -1280 replies
3/21Make vma_dump_size() genericfs/binfmt_elf.c fs/elfcore-common.c include/linux/elfcore-internal.h+19 -121 reply
4/21Make fill_psinfo genericfs/binfmt_elf.c+14 -33 replies
5/21Rename compat versions of the reusable core generation routinesfs/compat_binfmt_elf.c+7 -02 replies
6/21Export the reusable ELF core generation routinesfs/binfmt_elf.c include/linux/elfcore-internal.h+34 -50 replies
7/21Define API for reading arch specif Program Headers for Coreinclude/linux/elfcore.h kernel/elfcore.c+9 -00 replies
8/21ia64 Implementation of elf_core_copy_extra_phdrs()arch/ia64/kernel/elfcore.c+34 -00 replies
9/21UML (i386) Implementation of elf_core_copy_extra_phdrs()arch/um/sys-i386/elfcore.c+32 -00 replies
10/21Create /proc/pid/core entryfs/proc/Makefile fs/proc/base.c fs/proc/gencore.c +1 more+51 -02 replies
11/21Track the core generation requestsfs/proc/gencore.c fs/proc/gencore.h+95 -22 replies
12/21Check if the process is an ELF executablefs/proc/gencore.c+31 -01 reply
13/21Freeze / Thaw threadsfs/proc/gencore.c+26 -01 reply
14/21Create ELF headerfs/proc/Makefile fs/proc/gencore-elf.c fs/proc/gencore.c +1 more+189 -11 reply
15/21Collect ELF Core notes datafs/proc/gencore-elf.c fs/proc/gencore.c fs/proc/gencore.h+268 -101 reply
16/21Wait for threads to freezefs/proc/gencore-elf.c fs/proc/gencore.c fs/proc/gencore.h+65 -01 reply
17/21Calculate the size of the core filefs/proc/gencore-elf.c fs/proc/gencore.h+7 -00 replies
18/21Generate the data sections for ELF Corefs/proc/gencore-elf.c+87 -33 replies
19/21Identify the ELF class of the processfs/proc/gencore.c fs/proc/gencore.h+16 -40 replies
20/21Add supporting for compat ELF class data structuresfs/proc/gencore-elf.c fs/proc/gencore.h+41 -140 replies
21/21Compat ELF class Core generation supportfs/proc/Makefile fs/proc/gencore-compat-elf.c fs/proc/gencore.c +1 more+70 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC] [Patch 0/21] Non disruptive application core dump infrastructure

Hi all,

This is series of patches implementing an infrastructure for capturing the core of an application without disrupting its process semantics.

The infrastructure makes use of the freezer subsystem in kernel to freeze the threads and then collect the information to generate the core.

The interface is provided by a /proc/pid/core file, reading which can give the ELF formatted core of the process with "pid". The interface supports "seek" operation on the fd, allowing the dumper to have control on the data that is being dumped. Also it allows the user to store the dump at any location.

The current implementation supports both native as well as the compat ELF tasks.

An open() call to the /proc/pid/core will try to freeze the threads in the process and the read() requests will dynamically generate the contents for the core file. The ELF header & Program Headers are stored in a kernel buffer to allow us to map the fpos to the required data section.

In case a thread is not frozen within a time interval, after issuing the freeze request, we fill the register state information with 0's to indicate we could not capture the data.

A close() would kick the threads out of the refrigerator().

The implementation reuses some of the existing ELF core generation code by exporting them. Some of the code common to both native and compat ELF class support has been moved to a common place, elfcore-common.c. Also some of the reusable functions, specific to the ELF class handling, has been made global, after renaming the compat version of the same.

We also added a new API -elf_core_copy_extra_phdrs() -for "reading" the arch specific program headers, versus the existing elf_core_write_extra_phdrs().

Patches 1 to 9 deals with re-arranging the ELF code to be reusable by the infrastructure.

Patches 10 to 21 implements the infrastructure.

TODO: Add support for collecting the arch specific notes, currently used only by Cell platform.

Please let me know your review comments / thoughts.

  arch/ia64/kernel/elfcore.c       |   34 ++
  arch/um/sys-i386/elfcore.c       |   32 ++
  fs/Makefile                      |    1
  fs/binfmt_elf.c                  |  162 +------------
  fs/compat_binfmt_elf.c           |    7
  fs/elfcore-common.c              |  138 +++++++++++
  fs/proc/Makefile                 |    2
  fs/proc/base.c                   |    1
  fs/proc/gencore-compat-elf.c     |   61 ++++
  fs/proc/gencore-elf.c            |  479+++++++++++++++++++++++++++++++++++++++ 
  fs/proc/gencore.c                |  297++++++++++++++++++++++++ 
  fs/proc/gencore.h                |   71 +++++
  fs/proc/internal.h               |    1
  include/linux/elfcore-internal.h |   73 +++++
  include/linux/elfcore.h          |    3
  include/linux/freezer.h          |   12
  kernel/elfcore.c                 |    6
  kernel/power/process.c           |    9
  18 files changed, 1241 insertions(+), 148 deletions(-)

Thanks

Suzuki