Complete set of clocksource/sched_clock patches
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 40 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 40 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/40] Complete set of clocksource/sched_clock patches
Quoted 130 lines · Mikael Pettersson
Here it is:
Build ATAG
ATAG_MEM: Overwriteram_endwith real_region_top=0x20000000, memsize=512 M
ATAG_MEM=536870912 at0xa0000000, MACH_TYPE=1101
Using base address0x00200000and length0x0018e3c0
Uncompressing Linux... done, booting the kernel.
Linux version 2.6.37-rc6 (mikpe at brewer) (gcc version 4.4.6 20101116 (prerelease) (GCC) ) #1 Sun Dec 19 12:58:45 CET 2010
CPU: XScale-80219 [69052e30] revision 0 (ARMv5TE), cr=0000397f
CPU: VIVT data cache, VIVT instruction cache
Machine: Thecus N2100
bootconsole [earlycon0] enabled
Memory policy: ECC disabled, Data cache writeback
pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768
pcpu-alloc: [0] 0
Built 1 zonelists in Zone order, mobility grouping on. Total pages: 130048
Kernel command line: console=ttyS0,115200 ro root=/dev/sda1 mem=512M at0xa0000000earlyprintk
PID hash table entries: 2048 (order: 1, 8192 bytes)
Dentry cache hash table entries: 65536 (order: 6, 262144 bytes)
Inode-cache hash table entries: 32768 (order: 5, 131072 bytes)
Memory: 512MB = 512MB total
Memory: 516424k/516424k available, 7864k reserved, 0K highmem
Virtual kernel memory layout:vector : 0xffff0000 - 0xffff1000 ( 4 kB) fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB) DMA : 0xffc00000 - 0xffe00000 ( 2 MB) vmalloc : 0xe0800000 - 0xfe000000 ( 472 MB) lowmem : 0xc0000000 - 0xe0000000 ( 512 MB) modules : 0xbf000000 - 0xc0000000 ( 16 MB) .init : 0xc0008000 - 0xc0022000 ( 104 kB) .text : 0xc0022000 - 0xc030d000 (2988 kB) .data : 0xc030e000 - 0xc0329d60 ( 112 kB) NR_IRQS:32 sched_clock: 32 bits at 198MHz, resolution 5ns, wraps every 21691ms Unable to handle kernel NULL pointer dereference at virtual address 00000000 pgd = c0004000 [00000000] *pgd=00000000 Internal error: Oops: 80000005 [#1] last sysfs file: Modules linked in: CPU: 0 Not tainted (2.6.37-rc6 #1) PC is at 0x0 LR is at iop_timer_interrupt+0x20/0x28 pc : [<00000000>] lr : [<c002b580>] psr: 400000d3sp :
c030fe98ip :c030fea8fp :c030fea4
r10:a001c494r9 :69052e30r8 :c0315a8c
r7 : 00000009 r6 : 00000000 r5 : 00000000 r4 :c0312fa0r3 : 00000000 r2 : 00000001 r1 :c0312fc8r0 :c0312fc8
Flags: nZcv IRQs off FIQs off ModeSVC_32ISA ARM Segment kernel
Control:0000397fTable:a0004000DAC: 00000017
Process swapper (pid: 0, stack limit =0xc030e270)Stack: (0xc030fe98 to 0xc0310000)fe80:
c030fec4c030fea8
fea0:c005ebfcc002b56cc0315a6800000009 00000200 60000053c030fedcc030fec8
fec0:c0060e78c005ebdc00000009 00000000c030fef4c030fee0c002207cc0060dd8
fee0: ffffffffc030ff2cc030ff6cc030fef8c0022ba8c002200c00000000 00000001
ff00: 00000000 00000000c0315a68c0312fa000000009 60000053c0315a8c69052e30
ff20:a001c494c030ff6cc030ff08c030ff40c00603e0c005f7cc60000053 ffffffff
ff40:52ef041b00000001c0312fa000000009c001d9e4c0311a58a001c704a001c494
ff60:c030ff84c030ff70c005fa54c005f598c0312fa00bcd3d80c030ffacc030ff88
ff80:c000c3a4c005fa38c0315560600000d3c0330020c0329d60c001d9e8c001d9e4
ffa0:c030ffbcc030ffb0c000bee4c000c358c030ffccc030ffc0c0009f54c000bedc
ffc0:c030fff4c030ffd0c0008a1cc0009f44c000865c00000000 00000000c001d9e8
ffe0:0000397dc0329e6400000000c030fff8a0008034c00088b800000000 00000000Backtrace: [<c002b560>] (iop_timer_interrupt+0x0/0x28) from [<c005ebfc>] (handle_IRQ_event+0x2c/0xfc) [<c005ebd0>] (handle_IRQ_event+0x0/0xfc) from [<c0060e78>] (handle_level_irq+0xac/0x11c) r7:60000053 r6:00000200 r5:00000009 r4:c0315a68 [<c0060dcc>] (handle_level_irq+0x0/0x11c) from [<c002207c>] (asm_do_IRQ+0x7c/0xa0) r5:00000000 r4:00000009 [<c0022000>] (asm_do_IRQ+0x0/0xa0) from [<c0022ba8>] (__irq_svc+0x48/0x80) Exception stack(0xc030fef8 to 0xc030ff40)fee0: 00000000 00000001
ff00: 00000000 00000000c0315a68c0312fa000000009 60000053c0315a8c69052e30
ff20:a001c494c030ff6cc030ff08c030ff40c00603e0c005f7cc60000053 ffffffff
r5:c030ff2c r4:ffffffff
[<c005f58c>] (__setup_irq+0x0/0x310) from [<c005fa54>] (setup_irq+0x28/0x2c) [<c005fa2c>] (setup_irq+0x0/0x2c) from [<c000c3a4>] (iop_init_time+0x58/0x108)
r5:0bcd3d80 r4:c0312fa0
[<c000c34c>] (iop_init_time+0x0/0x108) from [<c000bee4>] (n2100_timer_init+0x14/0x1c)
r6:c001d9e4 r5:c001d9e8 r4:c0329d60
[<c000bed0>] (n2100_timer_init+0x0/0x1c) from [<c0009f54>] (time_init+0x1c/0x24) [<c0009f38>] (time_init+0x0/0x24) from [<c0008a1c>] (start_kernel+0x170/0x264) [<c00088ac>] (start_kernel+0x0/0x264) from [<a0008034>] (0xa0008034)
r5:c0329e64 r4:0000397dCode: bad PC value ---[ end trace 1b75b31a2719ed1c ]--- Kernel panic - not syncing: Fatal exception in interrupt Backtrace: [<c0026314>] (dump_backtrace+0x0/0x118) from [<c025b65c>] (dump_stack+0x18/0x1c) r7:00000000 r6:c030e270 r5:c032a030 r4:c032a030 [<c025b644>] (dump_stack+0x0/0x1c) from [<c025b6c4>] (panic+0x64/0x188) [<c025b660>] (panic+0x0/0x188) from [<c0026758>] (die+0x194/0x1d8) r3:00010000 r2:c030fcf8 r1:00001315 r0:c02ca1bf r7:00000000 [<c00265c4>] (die+0x0/0x1d8) from [<c00285d8>] (__do_kernel_fault+0x6c/0x90) r8:00000000 r7:80000005 r6:00000000 r5:c030fe50 r4:00000000 [<c002856c>] (__do_kernel_fault+0x0/0x90) from [<c00287b8>] (do_page_fault+0x1bc/0x1d4) r9:000000d3 r8:00000000 r7:00000000 r6:00000000 r5:c030fe50r4:c0310df8
[<c00285fc>] (do_page_fault+0x0/0x1d4) from [<c0028868>] (do_translation_fault+0x24/0xac) [<c0028844>] (do_translation_fault+0x0/0xac) from [<c0022230>] (do_PrefetchAbort+0x3c/0xa0)
r7:c030fe50 r6:00000000 r5:c0311e5c r4:00000005
[<c00221f4>] (do_PrefetchAbort+0x0/0xa0) from [<c0022c90>] (__pabt_svc+0x50/0x80)Exception stack(0xc030fe50 to 0xc030fe98)fe40:
c0312fc8c0312fc800000001 00000000
fe60:c0312fa000000000 00000000 00000009c0315a8c69052e30a001c494c030fea4
fe80:c030fea8c030fe98c002b58000000000400000d3ffffffff
r7:00000009 r6:00000000 r5:c030fe84 r4:ffffffff
[<c002b560>] (iop_timer_interrupt+0x0/0x28) from [<c005ebfc>] (handle_IRQ_event+0x2c/0xfc) [<c005ebd0>] (handle_IRQ_event+0x0/0xfc) from [<c0060e78>] (handle_level_irq+0xac/0x11c)
r7:60000053 r6:00000200 r5:00000009 r4:c0315a68
[<c0060dcc>] (handle_level_irq+0x0/0x11c) from [<c002207c>] (asm_do_IRQ+0x7c/0xa0)
r5:00000000 r4:00000009
[<c0022000>] (asm_do_IRQ+0x0/0xa0) from [<c0022ba8>] (__irq_svc+0x48/0x80)Exception stack(0xc030fef8 to 0xc030ff40)fee0: 00000000 00000001
ff00: 00000000 00000000c0315a68c0312fa000000009 60000053c0315a8c69052e30
ff20:a001c494c030ff6cc030ff08c030ff40c00603e0c005f7cc60000053 ffffffff
r5:c030ff2c r4:ffffffff
[<c005f58c>] (__setup_irq+0x0/0x310) from [<c005fa54>] (setup_irq+0x28/0x2c) [<c005fa2c>] (setup_irq+0x0/0x2c) from [<c000c3a4>] (iop_init_time+0x58/0x108)
r5:0bcd3d80 r4:c0312fa0
[<c000c34c>] (iop_init_time+0x0/0x108) from [<c000bee4>] (n2100_timer_init+0x14/0x1c)
r6:c001d9e4 r5:c001d9e8 r4:c0329d60
[<c000bed0>] (n2100_timer_init+0x0/0x1c) from [<c0009f54>] (time_init+0x1c/0x24) [<c0009f38>] (time_init+0x0/0x24) from [<c0008a1c>] (start_kernel+0x170/0x264) [<c00088ac>] (start_kernel+0x0/0x264) from [<a0008034>] (0xa0008034)
r5:c0329e64 r4:0000397d
Quoted 6 lines
We take an early timer interrupt and call NULL in the
evt->event_handler(evt);statement in
iop_timer_interrupt(). Apparently the evt (dev_id) passed to the interrupt handler isn't initialized at this point.
evt is initialized, it's done statically:
static struct irqaction iop_timer_irq = {
.dev_id = &iop_clockevent,
};
What isn't initialized at this early point is evt->event_handler.
Quoted 5 lines
The most visible change the
sched_clockpatches did in plat-iop was to add a call toinit_sched_clock()at the very start ofiop_init_time(), before the timer IRQ, clockevent, and clocksource have been set up. Moving that call to the very end ofiop_init_time()[see below] made the kernel boot again, and the interactivity problems were also solved.
I think this is a bug just waiting to happen, and the sched_clock patch just gives it a helping hand (by accidentally enabling interrupts early
- and that's something which also needs fixing.)
Here's the event device setup code:
write_tmr0(timer_ctl & ~IOP_TMR_EN);
setup_irq(IRQ_IOP_TIMER0, &iop_timer_irq);
clockevents_calc_mult_shift(&iop_clockevent,
tick_rate, IOP_MIN_RANGE);
iop_clockevent.max_delta_ns =
clockevent_delta2ns(0xfffffffe, &iop_clockevent);
iop_clockevent.min_delta_ns =
clockevent_delta2ns(0xf, &iop_clockevent);
iop_clockevent.cpumask = cpumask_of(0);
clockevents_register_device(&iop_clockevent);
write_trr0(ticks_per_jiffy - 1);
write_tcr0(ticks_per_jiffy - 1);
write_tmr0(timer_ctl);First thing is that although the timer is stopped before the IRQ is registered, there is no clearing of any pending timer interrupt at that time. As we don't know what state the timer was in, we can't be sure that the interrupt isn't already pending.
Second thing is why is the timer being enabled by this code after it's been registered. This is something which should be done by the clockevents code when it's ready via the ->set_mode callback, not when the platform decides to do so - otherwise you can call the interrupt handler when evt->event_handler has not been setup.
So, I think this will solve the IOP misbehaviour. What I don't know is what the cryptic txx0() suffixes on these write statements are (what's the difference between trr and tcr? tcr = timer counter register, trr = timer ? register? Does trr need to be written in ->set_mode (if so that's another bug in this code)?
arch/arm/plat-iop/time.c +1 -3
@@ -162,6 +162,7 @@ void __init iop_init_time(unsigned long tick_rate)* Set up interrupting clockevent timer 0. */ write_tmr0 (timer_ctl & ~IOP_TMR_EN ); +write_tisr (1 );setup_irq (IRQ_IOP_TIMER0 , &iop_timer_irq);clockevents_calc_mult_shift (&iop_clockevent, tick_rate,IOP_MIN_RANGE );
@@ -171,9 +172,6 @@ void __init iop_init_time(unsigned long tick_rate)clockevent_delta2ns (0xf , &iop_clockevent); iop_clockevent.cpumask =cpumask_of (0 );clockevents_register_device (&iop_clockevent); -write_trr0 (ticks_per_jiffy -1 ); -write_tcr0 (ticks_per_jiffy -1 ); -write_tmr0 (timer_ctl);/* * Set up free-running clocksource timer 1.