Skip to content

OCFS2: Add trace event and replace mlog(0).

Joel Becker ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 34 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 34 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 00/34] OCFS2: Add trace event and replace mlog(0).
Quoted 6 lines · Tao Ma
Quoted 4 lines · Joel Becker

Overall this seems pretty straightforward. There wasn't a lot
of editing of masklog entries; we still have a million tracepoints. I wonder how much memory that will use. Have you checked the space usage of all the sysfs files for all of our tracepoints?

Sorry, I don't know how to check the space usage of these files. any tips?

Just count the number of files and directories added to sysfs.
I believe the files disappear when not open, but the directories I think have inode and dentry structures around permanently..

Quoted 7 lines
Quoted 3 lines

Well, one generic comment. It seems a lot of our log messages
have gone from "ocfs2_foo(): Change blah 0x%p to new_blah 0x%p" to "ocfs2_foo(): %p %p". I wonder if that is going to be hard to read.

Yeah, I used to think of adding all these descriptive strings to trace buffers, but finally I gave up. The reason is that no matter how we print the message in the trace buffer, we have to go to read the codes and with the codes, everything should be clear enough. ;)

Ok, we'll give it a shot.

Joel

Signature · 6 lines
"The opposite of a correct statement is a false statement. The
 opposite of a profound truth may well be another profound truth."
         - Niels Bohr 

			http://www.jlbec.org/
			jlbec at evilplan.org