Skip to content

Fix issues with ARMv6+v6k+v7 kernels

Tony Lindgren linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 of 14 patches 0 repliesNew

13 of 14 patches are in this archive. The cover letter announces 14.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer+0 -00 replies
2/14ARM: bitops: switch set/clear/change bitops to use ldrex/strex+0 -00 replies
3/14ARM: v6k: remove CPU_32v6K dependencies in asm/spinlock.h+0 -00 replies
4/14ARM: v6k: introduce CPU_V6K option+0 -00 replies
7/14ARM: v6k: select clear exclusive code seqences according to V6 variants+0 -00 replies
8/14ARM: v6k: select cmpxchg code sequences according to V6 variants+0 -00 replies
9/14ARM: v6k: select generic atomic64 code according to V6 variants+0 -00 replies
10/14ARM: v6k: select TLS register code according to V6 variants+0 -00 replies
11/14ARM: v6k: use CPU domain feature if we include support for arch < ARMv6K+0 -00 replies
11/14ARM: v6k: use CPU domain feature if we include support for arch < ARMv6K+0 -00 replies
12/14ARM: v6k: do not disable CPU_32v6K based on platform selection+0 -00 replies
13/14ARM: v6k: allow swp emulation again when ARMv7 is enabled+0 -00 replies
14/14ARM: v6k: only allow SMP if we have v6k or v7 CPU+0 -00 replies

Reviews trailers per patch

8 of 13 patches have a Reviewed-by or Acked-by.

PatchTony Lindgren
1/14T-b
2/14T-b
3/14T-b
4/14A-b
7/14A-b
8/14A-b
9/14A-b
10/14A-b
11/14A-b
11/14A-b
12/14T-b
13/14T-b
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] Fix issues with ARMv6+v6k+v7 kernels
Quoted 21 lines · Russell King - ARM Linux

This patch series reworks the ARMv6/ARMv6K support options, code selection, and bit operations such that it's possible to safely build a kernel which supports ARMv6, ARMv6K, ARMv7 and ARMv7 SMP in one image.

Currently, we use CPU_V6 for both ARMv6 and ARMv6K, setting CPU_32v6K if we have the K extensions. CPU_32v6K directly controlled whether we should include the ARMv6K instructions (clrex, load/store exclusive byte, half-word, double). As the bitops code uses the load/store exclusive byte operations, unsetting CPU_32v6K results in these falling back to their non-SMP local-irq-disabling variants. These are only safe in uniprocessor environments.

So, the first two patches convert the bitops to use the ARMv6 load/store exclusive word operations - and ensuring correctness by ensuring that the pointer passed in is word-aligned.

We then introduce a new CPU_V6K which indicates that we're including an ARMv6K CPU in the build, which frees up CPU_V6 to mean that we're including an ARMv6 non-K CPU.

Quoted 6 lines

We can then use CPU_V6 to ensure that the non-v6K code paths which are still SMP safe are selected.

Without this patch set, such a kernel will be unsafe when run on SMP platforms as it omits necessary SMP code to ensure that bit operations are safe.

Amazing, based on a quick test this series boots just fine on non-v6K omap2420 using omap2plus_defconfig :)

Tony