Skip to content

Fix alignment of custom sections made from structures (v3)

Mathieu Desnoyers lkml sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3introduce __u64_aligned and U64_ALIGN() for structure alignment in custom sections (v3)include/asm-generic/vmlinux.lds.h include/linux/align-section.h include/linux/compiler.h+62 -06 replies
2/3tracing: fix sparc64 alignment crash with __u64_aligned/U64_ALIGN()include/asm-generic/vmlinux.lds.h include/linux/compiler.h include/linux/ftrace_event.h +5 more+29 -303 replies
3/3tracepoints: use __u64_aligned/U64_ALIGN()include/asm-generic/vmlinux.lds.h include/linux/tracepoint.h+5 -92 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDavid S. Miller
1/3A-b A-b
2/3A-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 0/3] Fix alignment of custom sections made from structures (v3)

Hello,

Here is a patchset that fixes the Ftrace-induced crash experienced on sparc64 discussed in the following thread: https://lkml.org/lkml/2011/1/16/2

The third patch changes the Tracepoints to use the more compact alignment scheme proposed here, even though their alignment on 32-byte works fine. This third patch is therefore not a fix per se.

The patchset is based on 2.6.37. Hopefully there are not too many things to update for the current -git.

Changelog since v2: drop the "packed" attribute, because it caused unaligned acceses on sparc64 by dropping the padding between consecutive "int" and "pointer"/"long" fields.

Comments are welcome,

Mathieu

Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com