Skip to content

Rework of the PTP support series core code

Thomas Gleixner lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest28 patches 82 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28time: Correct the *settime* parametersdrivers/char/mmtimer.c include/linux/posix-timers.h include/linux/security.h +6 more+18 -153 replies
2/28posix-timers: Define nanosleep not supported error separatekernel/posix-timers.c+9 -52 replies
3/28posix-timers: Cleanup struct initializersdrivers/char/mmtimer.c kernel/posix-cpu-timers.c kernel/posix-timers.c+38 -382 replies
4/28posix-timers: Introduce clock_posix_cpuinclude/linux/posix-timers.h kernel/posix-cpu-timers.c+14 -02 replies
5/28posix-timers: Introduce clockid_to_kclock()kernel/posix-timers.c+10 -02 replies
6/28posix-timers: Convert clock_nanosleep to clockid_to_kclock()drivers/char/mmtimer.c include/linux/posix-timers.h kernel/posix-timers.c+7 -222 replies
7/28posix-timers: Convert clock_nanosleep_restart to clockid_to_kclock()kernel/posix-timers.c+5 -124 replies
8/28posix-timers: Cleanup restart_block usagekernel/posix-cpu-timers.c kernel/posix-timers.c+16 -243 replies
9/28thread_info: Remove legacy arg0-3 from restart_blockinclude/linux/thread_info.h+0 -32 replies
10/28posix-cpu-timers: Remove the stub nanosleep functionskernel/posix-cpu-timers.c+0 -112 replies
11/28posix-timers: Convert clock_settime to clockid_to_kclock()include/linux/posix-timers.h kernel/posix-cpu-timers.c kernel/posix-timers.c+12 -242 replies
12/28posix-timers: Convert clock_gettime() to clockid_to_kclock()kernel/posix-timers.c+15 -134 replies
13/28posix-timers: Convert clock_getres() to clockid_to_kclock()drivers/char/mmtimer.c kernel/posix-timers.c+14 -132 replies
14/28posix-timers: Remove useless res field from k_clockdrivers/char/mmtimer.c include/linux/posix-timers.h kernel/posix-timers.c+2 -62 replies
15/28posix-timers: Convert timer_create() to clockid_to_kclock()kernel/posix-timers.c+15 -252 replies
16/28posix-timers: Convert timer_settime() to clockid_to_kclock()kernel/posix-timers.c+5 -22 replies
17/28posix-timers: Convert timer_gettime() to clockid_to_kclock()kernel/posix-timers.c+6 -22 replies
18/28posix-timers: Convert timer_delete() to clockid_to_kclock()kernel/posix-timers.c+5 -14 replies
19/28posix-timers: Remove CLOCK_DISPATCH leftoverskernel/posix-timers.c+0 -222 replies
20/28posix-timers: Make posix-cpu-timers functions staticinclude/linux/posix-timers.h kernel/posix-cpu-timers.c+37 -483 replies
21/28posix-timer: Update commentkernel/posix-timers.c+7 -182 replies
22/28time: Introduce timekeeping_inject_offsetinclude/linux/time.h kernel/time/timekeeping.c+37 -01 reply
23/28ntp: Add ADJ_SETOFFSET mode bitinclude/linux/timex.h kernel/time/ntp.c+13 -11 reply
24/28posix-clocks: Splitout compat timex accessorskernel/compat.c+65 -482 replies
25/28posix clocks: Introduce a syscall for clock tuning.include/linux/posix-timers.h include/linux/syscalls.h kernel/compat.c +1 more+57 -02 replies
26/28posix_clocks: Add clock_adjtime for x86arch/x86/ia32/ia32entry.S arch/x86/include/asm/unistd_32.h arch/x86/include/asm/unistd_64.h +1 more+6 -12 replies
27/28posix-timers: Add support for fd based clocksinclude/linux/posix-timers.h kernel/posix-timers.c+14 -14 replies
28/28posix clocks: Introduce dynamic clocksinclude/linux/posix-clock.h include/linux/posix-timers.h kernel/posix-timers.c +2 more+601 -311 replies

Reviews trailers per patch

27 of 28 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohn StultzRichard Cochran
SeriesA-b T-b
1/28A-b A-b
2/28A-b A-b T-b
3/28A-b A-b T-b
4/28A-b A-b T-b
5/28A-b A-b
6/28A-b A-b T-b
7/28A-b T-b
8/28A-b A-b T-b
9/28A-b A-b T-b
10/28A-b A-b T-b
11/28A-b A-b T-b
12/28A-b A-b T-b
13/28A-b A-b T-b
14/28A-b A-b T-b
15/28A-b A-b T-b
16/28A-b T-b
17/28A-b T-b
18/28A-b T-b
19/28A-b A-b T-b
20/28A-b T-b
21/28A-b A-b
22/28
23/28A-b
24/28A-b A-b
25/28A-b A-b
26/28A-b A-b
27/28A-b A-b
28/28A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 00/28] Rework of the PTP support series core code

This is a rework of Richards PTP support series core code. The PTP driver patches are unchanged and not included in this series.

The reason for this rework is that I got scared when reviewing:
[PATCH V10 09/15] posix clocks: cleanup the CLOCK_DISPTACH macro

The patch is really too large and the risk of wreckage too high. So instead of whipping Richard through another round I reworked the series in the following way:

1) Split the CLOCK_DISPATCH cleanup in fine grained steps.

That allowed further cleanups and got rid of 200 lines of code and made a lot of functions static.

It also fixes subtle changes to the error return codes which happened in the large all in one overhaul (EINVAL vs. ENOTSUP).

2) Move the patches which add new functionality after the cleanup.

It does not make sense to add new functionality into the old scheme first and then clean it up.

Richard, can you please run that through your testing ? The PTP drivers apply on top of that.

Thanks,

tglx