Skip to content

e1000: multi-buffer packet support

Michael S. Tsirkin qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/23 patches 4 repliesIn review
  2. v2 posting 1/21 patch 4 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v2 from the cover letter

fix buffer overflow reported by Kevin
added a patch to fix EOP spec violation reported by Juan added a patch to fix spec violation noted by myself

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3e1000: multi-buffer packet supporthw/e1000.c+28 -110 replies
2/3e1000: clear EOP for multi-buffer descriptorshw/e1000.c+4 -20 replies
3/3e1000: verify we have buffers, upfronthw/e1000.c+22 -60 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan HajnocziAlex WilliamsonKevin Wolf
SeriesA-b A-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCHv2 0/3] e1000: multi-buffer packet support

e1000 supports multi-buffer packets larger than rxbuf_size.

This fixes the following (on linux):
- in guest: ifconfig eth1 mtu 16110
- in host: ifconfig tap0 mtu 16110

           ping -s 16082 <guest-ip>

Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205

Changes from v1:
fix buffer overflow reported by Kevin
added a patch to fix EOP spec violation reported by Juan added a patch to fix spec violation noted by myself

Michael S. Tsirkin (3):
e1000: multi-buffer packet support
e1000: clear EOP for multi-buffer descriptors
e1000: verify we have buffers, upfront

 hw/e1000.c |   61 +++++++++++++++++++++++++++++++++++++++++++++++------------
 1 files changed, 48 insertions(+), 13 deletions(-)
Signature · 1 line
1.7.3.2.91.g446ac