Skip to content

Add support for RX network flow classifier rules

Alexander Duyck netdev 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 14 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2Add macro for displaying [value N] formatting to manpageethtool.8.in+38 -641 reply
2/2Add RX packet classification interfaceMakefile.am ethtool-bitops.h ethtool-util.h +3 more+1077 -1813 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [ethtool PATCH 0/2] Add support for RX network flow classifier rules

These two patches add support for the RX network flow classifier set and get rules calls already supported by the kernel. The first patch is actually just a cleanup patch in the manpage to make it a bit easier to do the value/mask pairing follow ons in the second patch.

The second patch is the meat of the changes and implements the packet classifier interface. In updating and testing it I found a number of issues that had to be addressed. In resolving them though I found several features that I felt were better off removed such as prioritization of filters which was causing multiple issues including memory leaks and non-constructive blocking of filter insertions due to the state of expanded priorities not being saved.

I'm still currently exploring my options in resolving the needs for ixgbe to have the ability to retain and display its filters and plan to submit RFC patches in the next few days to get some feedback on that.

Thanks,

Alex

---

Alexander Duyck (1):
Add macro for displaying [value N] formatting to manpage

Santwona Behera (1):
Add RX packet classification interface

 Makefile.am      |    3 
 ethtool-bitops.h |   25 ++
 ethtool-util.h   |   13 +
 ethtool.8.in     |  203 +++++++++-----
 ethtool.c        |  144 +++++++++-
 rxclass.c        |  809 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 1115 insertions(+), 82 deletions(-)
 create mode 100644 ethtool-bitops.h
 create mode 100644 rxclass.c