RFC Rework tty helpers to avoid need for file pointers
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | tiocmget: kill off the passing of the struct filedrivers/ drivers/ drivers/ +66 more | +98 | 0 replies | |
| 2/6 | tiocmset: kill the file pointer argumentdrivers/ drivers/ drivers/ +67 more | +123 | 0 replies | |
| 3/6 | tty: remove filp from the USB tty ioctlsdrivers/ drivers/ drivers/ +20 more | +31 | 0 replies | |
| 4/6 | tty: now phase out the ioctl file pointer for gooddrivers/ drivers/ drivers/ +38 more | +66 | 1 reply | |
| 5/6 | tty: add a helper for setting termios data from kernel sidedrivers/ include/ | +10 | 0 replies | |
| 6/6 | hci_ath: Fix the mess in this driverdrivers/ | +13 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by.
| Patch | Alan Cox |
|---|---|
| 1/6 | |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 | Signed-of-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/6] Rework tty helpers to avoid need for file pointers
(and then use this to fix the holes in hci_ath)
The cleanup wants doing anyway but we have a reason for needing to do it.
---
Alan Cox (6):
hci_ath: Fix the mess in this driver
tty: add a helper for setting termios data from kernel side
tty: now phase out the ioctl file pointer for good
tty: remove filp from the USB tty ioctls
tiocmset: kill the file pointer argument
tiocmget: kill off the passing of the struct file
drivers/bluetooth/hci_ath.c | 26 +++++++++++++------------- drivers/char/amiserial.c | 8 ++++---- drivers/char/cyclades.c | 6 +++--- drivers/char/epca.c | 16 ++++++++-------- drivers/char/ip2/ip2main.c | 12 ++++++------ drivers/char/isicom.c | 8 ++++---- drivers/char/istallion.c | 8 ++++---- drivers/char/moxa.c | 12 ++++++------ drivers/char/mxser.c | 8 ++++---- drivers/char/nozomi.c | 8 ++++---- drivers/char/pcmcia/ipwireless/tty.c | 8 ++++---- drivers/char/pcmcia/synclink_cs.c | 10 +++++----- drivers/char/riscom8.c | 8 ++++---- drivers/char/rocket.c | 8 ++++---- drivers/char/ser_a2232.c | 6 +++--- drivers/char/serial167.c | 7 +++---- drivers/char/specialix.c | 8 ++++---- drivers/char/stallion.c | 9 ++++----- drivers/char/sx.c | 8 ++++---- drivers/char/synclink.c | 13 ++++++------- drivers/char/synclink_gt.c | 19 +++++++++---------- drivers/char/synclinkmp.c | 17 ++++++++--------- drivers/char/ttyprintk.c | 2 +- drivers/char/vme_scc.c | 4 ++-- drivers/isdn/capi/capi.c | 10 ++-------- drivers/isdn/gigaset/interface.c | 12 ++++++------ drivers/isdn/gigaset/ser-gigaset.c | 2 +- drivers/isdn/i4l/isdn_tty.c | 7 +++---- drivers/mmc/card/sdio_uart.c | 4 ++-- drivers/net/irda/irtty-sir.c | 2 +- drivers/net/usb/hso.c | 10 +++++----- drivers/net/wan/pc300_tty.c | 9 ++++----- drivers/staging/quatech_usb2/quatech_usb2.c | 6 +++--- drivers/staging/serqt_usb2/serqt_usb2.c | 13 ++++++------- drivers/tty/hvc/hvsi.c | 6 +++--- drivers/tty/n_gsm.c | 6 +++--- drivers/tty/pty.c | 4 ++-- drivers/tty/serial/68328serial.c | 2 +- drivers/tty/serial/68360serial.c | 6 +++--- drivers/tty/serial/crisv10.c | 7 +++---- drivers/tty/serial/ifx6x60.c | 5 ++--- drivers/tty/serial/serial_core.c | 16 ++++++---------- drivers/tty/tty_io.c | 17 ++++++++--------- drivers/tty/tty_ioctl.c | 14 +++++++++----- drivers/tty/vt/vt_ioctl.c | 6 +++--- drivers/usb/class/cdc-acm.c | 6 +++--- drivers/usb/serial/ark3116.c | 6 +++--- drivers/usb/serial/belkin_sa.c | 8 ++++---- drivers/usb/serial/ch341.c | 7 +++---- drivers/usb/serial/cp210x.c | 19 +++++++++---------- drivers/usb/serial/cypress_m8.c | 12 ++++++------ drivers/usb/serial/digi_acceleport.c | 14 +++++++------- drivers/usb/serial/ftdi_sio.c | 12 ++++++------ drivers/usb/serial/io_edgeport.c | 12 ++++++------ drivers/usb/serial/io_ti.c | 6 +++--- drivers/usb/serial/iuu_phoenix.c | 4 ++-- drivers/usb/serial/keyspan.c | 4 ++-- drivers/usb/serial/keyspan.h | 5 ++--- drivers/usb/serial/keyspan_pda.c | 4 ++-- drivers/usb/serial/kl5kusb105.c | 8 ++++---- drivers/usb/serial/kobil_sct.c | 12 ++++++------ drivers/usb/serial/mct_u232.c | 12 ++++++------ drivers/usb/serial/mos7720.c | 8 ++++---- drivers/usb/serial/mos7840.c | 6 +++--- drivers/usb/serial/opticon.c | 4 ++-- drivers/usb/serial/oti6858.c | 12 ++++++------ drivers/usb/serial/pl2303.c | 6 +++--- drivers/usb/serial/sierra.c | 4 ++-- drivers/usb/serial/spcp8x5.c | 6 +++--- drivers/usb/serial/ssu100.c | 6 +++--- drivers/usb/serial/ti_usb_3410_5052.c | 14 +++++++------- drivers/usb/serial/usb-serial.c | 12 ++++++------ drivers/usb/serial/usb-wwan.h | 6 +++--- drivers/usb/serial/usb_wwan.c | 6 +++--- drivers/usb/serial/whiteheat.c | 12 ++++++------ include/linux/tty.h | 3 ++- include/linux/tty_driver.h | 13 ++++++------- include/linux/usb/serial.h | 6 +++--- include/net/irda/ircomm_tty.h | 6 +++--- net/bluetooth/rfcomm/tty.c | 6 +++--- net/irda/ircomm/ircomm_tty_ioctl.c | 12 ++++++------ 81 files changed, 341 insertions(+), 361 deletions(-)
Signature · 1 line
Signature