Skip to content

Mark "init", "clone", and "add" output for translation

Jonathan Nieder git 1 version In review

Get series with b4
b4 am 20110221101229.GA32137@elie

Versions newest first

  1. v3 Latest15 patches 9 repliesIn review

Changes from v1 from the cover letter

- clearer commit messages, hopefully
- clearer documentation for GETTEXT_POISON in the makefile

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15i18n: add no-op _() and N_() wrappersMakefile cache.h gettext.h+28 -00 replies
2/15tests: add GETTEXT_POISON to simulate unfriendly translatorMakefile gettext.h t/test-lib.sh+17 -12 replies
3/15i18n: do not poison translations unless GIT_GETTEXT_POISON envvar is setMakefile gettext.c gettext.h +1 more+26 -30 replies
4/15Makefile: "pot" target to extract messages marked for translationMakefile po/.gitignore+17 -03 replies
5/15init: mark basic messages for translationbuiltin/init-db.c+23 -230 replies
6/15init: mark "Initialized [...] repository" for translationbuiltin/init-db.c t/t0001-init.sh+10 -40 replies
7/15clone: mark basic messages for translationbuiltin/clone.c+27 -270 replies
8/15clone: split "Cloning into" message into twobuiltin/clone.c+6 -30 replies
9/15clone: mark "Cloning into" message for translationbuiltin/clone.c t/t5601-clone.sh+3 -30 replies
10/15add: mark basic messages for translationbuiltin/add.c+18 -180 replies
11/15add: mark "The following paths are ignored" for translationbuiltin/add.c t/t2204-add-ignored.sh t/t3700-add.sh+33 -170 replies
12/15add: mark "did not match any files" for translationbuiltin/add.c t/t3700-add.sh+7 -30 replies
13/15add -u --verbose: mark "remove '%s'" for translationbuiltin/add.c t/t2200-add-update.sh+2 -20 replies
14/15update-index --refresh --porcelain: add missing constcache.h read-cache.c+3 -30 replies
15/15add --refresh --verbose: mark "Unstaged changes" heading for translationbuiltin/add.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/15] Mark "init", "clone", and "add" output for translation

Hi again,

To make the primitives introduced by v2 more concrete, here's a series including a few gettextization patches. I don't plan to send more of these unless there is some agreement that the basic structure is right. Maybe by next time I'll hunker down and write myself a tool to check that a commit only inserts "_("-")" pairs (maybe using diff --word-diff?)

This series still includes the skeleton gettext.h wrapper.

Changes from v1:

- clearer commit messages, hopefully
- clearer documentation for GETTEXT_POISON in the makefile

Please feel free to try it out, complain, ack, send patches, and so on.

Jonathan Nieder (2):
i18n: do not poison translations unless GIT_GETTEXT_POISON envvar is
set
update-index --refresh --porcelain: add missing const

Ævar Arnfjörð Bjarmason (13):
i18n: add no-op _() and N_() wrappers
tests: add GETTEXT_POISON to simulate unfriendly translator
Makefile: "pot" target to extract messages marked for translation
init: mark basic messages for translation
init: mark "Initialized [...] repository" for translation
clone: mark basic messages for translation
clone: split "Cloning into" message into two
clone: mark "Cloning into" message for translation
add: mark basic messages for translation
add: mark "The following paths are ignored" for translation
add: mark "did not match any files" for translation add -u --verbose: mark "remove '%s'" for translation add --refresh --verbose: mark "Unstaged changes" heading for
translation

 Makefile               |   27 ++++++++++++++++++++
 builtin/add.c          |   50 +++++++++++++++++++-------------------
 builtin/clone.c        |   63 +++++++++++++++++++++++++----------------------
 builtin/init-db.c      |   58 ++++++++++++++++++++++++-------------------
 cache.h                |    3 +-
 gettext.c              |   14 ++++++++++
 gettext.h              |   32 ++++++++++++++++++++++++
 po/.gitignore          |    1 +
 read-cache.c           |    4 +-
 t/t0001-init.sh        |    2 +-
 t/t2200-add-update.sh  |    2 +-
 t/t2204-add-ignored.sh |   37 +++++++++++++++++++---------
 t/t3700-add.sh         |   13 +++++++--
 t/t5601-clone.sh       |    2 +-
 t/test-lib.sh          |    9 +++++++
 15 files changed, 215 insertions(+), 102 deletions(-)
 create mode 100644 gettext.c
 create mode 100644 gettext.h
 create mode 100644 po/.gitignore