Skip to content

fix up /proc/$pid/smaps to not split huge pages

Dave Hansen linux-mm lkml 1 version In review

Get series with b4
b4 am 20110222015338.309727CA@kernel

Versions newest first

  1. v1 Latest5 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5pagewalk: only split huge pages when necessaryfs/proc/task_mmu.c include/linux/mm.h mm/memcontrol.c +1 more+32 -62 replies
2/5break out smaps_pte_entry() from smaps_pte_range()fs/proc/task_mmu.c+46 -392 replies
3/5pass pte size argument in to smaps_pte_entry()fs/proc/task_mmu.c+12 -122 replies
4/5teach smaps_pte_range() about THP pmdsfs/proc/task_mmu.c+21 -23 replies
5/5have smaps show transparent huge pagesfs/proc/task_mmu.c+4 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMel GormanJohannes WeinerDavid RientjesAndrea ArcangeliEric B Munson
1/5A-b A-b Reviewed-and-tested-by
2/5A-b A-b A-b Reviewed-and-tested-by
3/5A-b A-b A-b Reviewed-and-tested-by
4/5A-b A-b Reviewed-and-tested-by
5/5A-b A-b Reviewed-and-tested-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/5] fix up /proc/$pid/smaps to not split huge pages

Andrew, these have gone through a couple of review rounds. Can they have a spin in -mm?

--

I'm working on some more reports that transparent huge pages and KSM do not play nicely together. Basically, whenever THP's are present along with KSM, there is a lot of attrition over time, and we do not see much overall progress keeping THP's around:

	http://sr71.net/~dave/ibm/038_System_Anonymous_Pages.png

(That's Karl Rister's graph, thanks Karl!)

However, I realized that we do not currently have a nice way to find out where individual THP's might be on the system. We have an overall count, but no way of telling which processes or VMAs they might be in.

I started to implement this in the /proc/$pid/smaps code, but quickly realized that the lib/pagewalk.c code unconditionally splits THPs up. This set reworks that code a bit and, in the end, gives you a per-map count of the numbers of huge pages. It also makes it possible for page walks to _not_ split THPs.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>