Workarounds and fixes for ntuple filters
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | ethtool: prevent null pointer dereference with NTUPLE set but no set_rx_ntuplenet/ | +3 | 4 replies | |
| 2/10 | ethtool: add ntuple flow specifier to network flow classifierinclude/ | +20 | 9 replies | |
| 3/10 | ixgbe: remove ntuple filteringdrivers/ drivers/ drivers/ | +48 | 0 replies | |
| 4/10 | ethtool: remove support for ETHTOOL_GRXNTUPLEinclude/ include/ net/ +1 more | +1 | 0 replies | |
| 5/10 | ixgbe: add support for different Rx packet buffer sizesdrivers/ drivers/ drivers/ +1 more | +7 | 0 replies | |
| 6/10 | ixgbe: update perfect filter framework to support retaining filtersdrivers/ drivers/ drivers/ +1 more | +376 | 0 replies | |
| 7/10 | ixgbe: add basic support for settting and getting nfc controlsdrivers/ | +60 | 0 replies | |
| 8/10 | ixgbe: add support for displaying ntuple filters via the nfc interfacedrivers/ drivers/ | +106 | 0 replies | |
| 9/10 | ixgbe: add support for nfc addition and removal of filtersdrivers/ drivers/ | +277 | 0 replies | |
| 10/10 | ixgbe: Add support for using the same fields as ntuple in nfcdrivers/ | +19 | 0 replies |
Reviews trailers per patch
1 of 10 patches has a Reviewed-by or Acked-by.
| Patch | Alexander Duyck |
|---|---|
| 1/10 | |
| 2/10 | A-b |
| 3/10 | |
| 4/10 | |
| 5/10 | |
| 6/10 | |
| 7/10 | |
| 8/10 | |
| 9/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [net-next-2.6 PATCH 00/10] Workarounds and fixes for ntuple filters
This patch series is meant to address issue in the implementation of ntuple filters in both ixgbe and the kernel. The main issue being that ntuple filters didn't support the ability for drivers to retain and display filters.
This series addresses it by removing the ETHTOOL_GRXNTUPLE interface from the kernel and extends the ethtool network flow classifier interface to handle the same fields that ntuple filters provide. I have a separate set of patches I will be emailing out in the next few minutes that will contain the ethtool user-space portion of these changes.
The patches labeled with RFC are currently just for comments as I am not submitting them directly to the netdev tree and will be instead submitting them to the Jeff Kirsher's Intel network driver tree for submission.
---
Alexander Duyck (10):
[RFC] ixgbe: Add support for using the same fields as ntuple in nfc [RFC] ixgbe: add support for nfc addition and removal of filters [RFC] ixgbe: add support for displaying ntuple filters via the nfc interface [RFC] ixgbe: add basic support for settting and getting nfc controls [RFC] ixgbe: update perfect filter framework to support retaining filters [RFC] ixgbe: add support for different Rx packet buffer sizes [RFC] ethtool: remove support for ETHTOOL_GRXNTUPLE
[RFC] ixgbe: remove ntuple filtering
ethtool: add ntuple flow specifier to network flow classifier
ethtool: prevent null pointer dereference with NTUPLE set but no set_rx_ntuple
drivers/net/ixgbe/ixgbe.h | 29 +- drivers/net/ixgbe/ixgbe_82598.c | 2 drivers/net/ixgbe/ixgbe_82599.c | 661 ++++++++++++++++++++----------------- drivers/net/ixgbe/ixgbe_dcb_nl.c | 47 +-- drivers/net/ixgbe/ixgbe_ethtool.c | 504 ++++++++++++++++++++++------ drivers/net/ixgbe/ixgbe_main.c | 90 +++-- drivers/net/ixgbe/ixgbe_type.h | 25 + drivers/net/ixgbe/ixgbe_x540.c | 2 include/linux/ethtool.h | 27 +- include/linux/netdevice.h | 3 net/core/dev.c | 5 net/core/ethtool.c | 302 ----------------- 12 files changed, 884 insertions(+), 813 deletions(-)