Skip to content

i18n: add ngettext stub

Jonathan Nieder git 1 version In review

Get series with b4
b4 am 20110309103104.GA30980@elie

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2i18n: add stub ngettext implementationgettext.h+8 -00 replies
2/2i18n: avoid conflict with ngettext from libintlgettext.h+6 -17 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/PATCH 0/2] i18n: add ngettext stub
Quoted 10 lines · Junio C Hamano
Quoted 6 lines · Jonathan Nieder

Yep. Is it safe to do this without the

#define ngettext git_ngettext
static inline const char *git_ngettext(...)

dance?

Heh you tell me.

Yegh. My general feeling was that we should make sure gettext.h works even if <libintl.h> was included elsewhere, just in case some system header decides to start including it. That makes life slightly less pleasant, since libintl.h does

#if defined __OPTIMIZE__ && !defined __cplusplus
[...]

 # define ngettext(msgid1, msgid2, n) dngettext (NULL, msgid1, msgid2, n)
[...]
 #endif	/* Optimizing.  */

How about this?

Jonathan Nieder (1):
i18n: avoid conflict with ngettext from libintl

Junio C Hamano (1):
i18n: add no-op ngettext() fallback

 gettext.h |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4.1

Read the cover letter in its thread