Skip to content

select_bad_process: improve the PF_EXITING check

Oleg Nesterov linux-mm lkml 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 0 repliesNew
  2. v10 of 1 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1select_bad_process: improve the PF_EXITING checkmm/oom_kill.c+16 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/1] select_bad_process: improve the PF_EXITING check
Quoted 18 lines · Oleg Nesterov
Quoted 16 lines · Oleg Nesterov
Quoted 14 lines · Oleg Nesterov

It is not tested. I do not pretend I really understand oom-killer in all details (although oom_kill.c itself is quite trivial).

The patch assumes that

oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch oom-skip-zombies-when-iterating-tasklist.patch

are dropped.

I think, this patch __might__ address the problems described in the changelog, but of course I am not sure.

Quoted 10 lines
Quoted 4 lines
Quoted 2 lines

I am relying on your and Kosaki's review, if you disagree with this change I won't argue.

And another uncompiled/untested/needs_review patch which might help.

              ^^^^^^^^^^

I meant, compile-tested only ;)

Quoted 2 lines

Nobody ever argued, the current PF_EXITING check is not very good. I do not know how much it is useful, but we can at least improve it.

Argh. Sorry for noise, I am sending v2. Changes:

- fix the typo in mm_is_exiting(), s/p/t/

- update the changelog

Oleg.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Read the cover letter in its thread