Skip to content

tests: unsetting variables that influence the outcome

Jonathan Nieder git 1 version In review

Get series with b4
b4 am 20110315064909.GA25738@elie

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests: protect against GIT_ATTR_NOGLOBAL from environmentt/t0003-attributes.sh+1 -00 replies
1/3gitattributes: drop support for GIT_ATTR_NOGLOBALattr.c+1 -60 replies
2/3tests: suppress global and system gitattributest/test-lib.sh+4 -12 replies
2/3config: drop support for GIT_CONFIG_NOGLOBALbuiltin/config.c cache.h config.c +4 more+4 -160 replies
3/3tests: scrub environment of GIT_* variablest/test-lib.sh+31 -06 replies
3/3tests: suppress system gitattributest/test-lib.sh+2 -10 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchJeff King
1/3Helped-by
1/3Helped-by
2/3Helped-by
2/3Helped-by
3/3Improved-by
3/3Improved-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] tests: unsetting variables that influence the outcome

Hi,

These patches were rotting in my tree so I thought I should try sending them out. Maybe they can be useful.

The theme: settings from the inherited environment like GIT_PAGER can break tests in undesirable ways. For example,

GIT_PAGER=more sh t5400-send-pack.sh -v -i

hangs.

Jonathan Nieder (3):
tests: protect against GIT_ATTR_NOGLOBAL from environment
tests: suppress global and system gitattributes
tests: scrub environment of GIT_* variables

 t/t0003-attributes.sh |    1 +
 t/test-lib.sh         |   36 +++++++++++++++++++++++++++++++++++-
 2 files changed, 36 insertions(+), 1 deletions(-)