Skip to content

tpm + tpm_tis : Various fixes

Stefan Berger lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 3 repliesIn review
  2. v18 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- following Rajiv's feedback. Splitting the durations and timeout patches in 3 parts.
- slightly rearranging the order of the patches

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12tpm: Use durations returned from TPMdrivers/char/tpm/tpm.c+4 -20 replies
2/12tpm: Adjust the durations if they are too smalldrivers/char/tpm/tpm.c+11 -60 replies
3/12tpm_tis: Introduce durations sysfs entrydrivers/char/tpm/tpm.c drivers/char/tpm/tpm.h drivers/char/tpm/tpm_tis.c+21 -10 replies
4/12tpm: Use interface timeouts returned from the TPMdrivers/char/tpm/tpm.c+4 -30 replies
5/12tpm: Adjust interface timeouts if they are too smalldrivers/char/tpm/tpm.c+9 -40 replies
6/12tpm_tis: Add timeouts sysfs entrydrivers/char/tpm/tpm.c drivers/char/tpm/tpm.h drivers/char/tpm/tpm_tis.c+22 -10 replies
7/12tpm: Fix display of data in pubek sysfs entrydrivers/char/tpm/tpm.c+16 -100 replies
8/12tpm_tis: Re-enable interrupts upon (S3) resumedrivers/char/tpm/tpm_tis.c+30 -00 replies
9/12tpm_tis: Delay ACPI S3 suspend while the TPM is busydrivers/char/tpm/tpm_tis.c+23 -50 replies
10/12tpm_tis: Fix the probing for interruptsdrivers/char/tpm/tpm.h drivers/char/tpm/tpm_tis.c+28 -60 replies
11/12tpm_tis: Probing function for Intel iTPM bugdrivers/char/tpm/tpm_tis.c+73 -40 replies
12/12tpm: Fix a typodrivers/char/tpm/tpm.c+1 -10 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by.

PatchGuillaume Chazarain
1/12T-b
2/12
3/12T-b
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 00/12] tpm + tpm_tis : Various fixes

This patchset fixes various issues in the general TPM driver and the TPM TIS driver. Some of the patches were previously posted, and are being re-posted without change, while other patches were refactored. This patchset applies to the tip of the main git tree.

Patches 1-6 are related to using the timeouts that the TPM reports, along with work-arounds for TPMs that don't report the timeouts in microseconds but rather in milliseconds.

Patch 7 fixes the display of the public key of the TPM's Endorsement Key in sysfs.

Patch 8 re-enables the TPM's interrupts after resume from S3.

Patch 9 is useful if the TPM is run in interrupt mode and delays the S3 suspend until the TPM has finished processing a command.

Patch 10 fixes several aspects of the code around the probing for interrupts.

Patch 11 introduces automatic probing for the Intel iTPM flaw. The probing is useful in combination with the 'force' module parameter that enables the interrupt mode on some machines but then ends up circumventing ACPI to determine whether an Intel iTPM is present to activate the work-around. So, in that case we can rely on the probing.

Patch 12 fixes a typo.

I have tested these patches on four different types of machines. They worked fine there even though the TPM could not be used in interrupt mode on all of them (IRQ line not connected?).

V2:
- following Rajiv's feedback. Splitting the durations and timeout patches in 3 parts.
- slightly rearranging the order of the patches

Regards,
Stefan