Skip to content

RFC scic: remove pointless stuctures

Christoph Hellwig linux-scsi 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2isci: remove base_controller abstractiondrivers/scsi/isci/core/sci_base_controller.h drivers/scsi/isci/core/sci_controller.h drivers/scsi/isci/core/scic_sds_controller.c +5 more+364 -6381 reply
2/2isci: remove base_request abstractiondrivers/scsi/isci/core/sci_base_remote_device.h drivers/scsi/isci/core/sci_base_request.h drivers/scsi/isci/core/scic_sds_controller.c +12 more+550 -9402 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH, RFC 0/2] scic: remove pointless stuctures

Start killing off the pointless sci_base* structures which do nothing but causing a lot of unreadable code by converting forth and back between them and the real structures.

I've done the sci_base_controller, and sci_base_request on a rainy sunday afternoon, but the port, phy and remote device also need the same treatment. And after that the sci_base_object crap needs to go in favour of just using container_of or properly typed pointers.

But I'll rather leave that to you Intel guys, spending more time on this codebase won't be good for my mental health.

Read the cover letter in its thread