RFC signal: sigprocmask fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest7 patches 28 repliesIn review
- v1 RFC6 patches 13 repliesSuperseded
Changes in v2 from the cover letter
- 2/7 change retarget_shared_pending() to accept mask, not ~mask
- 3/7 is new, it adds the optimization promised in 2/7
- 4/7 add the small comment about current->blocked as Matt suggested
- 5/7 add the new helper, set_current_blocked(), suggested by Linus
- 8/7 is the new and a bit off-topic cleanup, but sys_rt_sigprocmask() looks so annoying
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | signal: introduce retarget_shared_pending()kernel/ | +17 | 2 replies | |
| 2/7 | signal: retarget_shared_pending: consider shared/unblocked signals onlykernel/ | +10 | 9 replies | |
| 3/7 | signal: retarget_shared_pending: optimize while_each_thread() loopkernel/ | +12 | 2 replies | |
| 4/7 | signal: sigprocmask: narrow the scope of ->siglockkernel/ | +13 | 2 replies | |
| 5/7 | signal: sigprocmask() should do retarget_shared_pending()include/ kernel/ | +17 | 2 replies | |
| 6/7 | x86: signal: handle_signal() should use set_current_blocked()arch/ | +4 | 2 replies | |
| 7/7 | x86: signal: sys_rt_sigreturn() should use set_current_blocked()arch/ | +1 | 3 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Matt Fleming | Tejun Heo | Mike Frysinger |
|---|---|---|---|
| Series | R-b R-b R-b R-b R-b R-b R-b R-b R-b | A-b A-b A-b A-b A-b A-b A-b A-b A-b | A-b |
| 1/7 | R-b | A-b | |
| 2/7 | R-b | A-b | |
| 3/7 | R-b | A-b | |
| 4/7 | R-b | A-b | |
| 5/7 | R-b | A-b | |
| 6/7 | R-b | A-b | |
| 7/7 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [RFC PATCH v2 0/7] signal: sigprocmask fixes
Andrew, please drop V1:
signal-introduce-retarget_shared_pending.patch signal-retarget_shared_pending-consider-shared-unblocked-signals-only.patch signal-sigprocmask-narrow-the-scope-of-sigloc.patch signal-sigprocmask-should-do-retarget_shared_pending.patch x86-signal-handle_signal-should-use-sigprocmask.patch x86-signal-sys_rt_sigreturn-should-use-sigprocmask.patch
Changes in V2:
- 2/7 change retarget_shared_pending() to accept mask, not ~mask
- 3/7 is new, it adds the optimization promised in 2/7
- 4/7 add the small comment about current->blocked as Matt suggested
- 5/7 add the new helper, set_current_blocked(), suggested by Linus
- 8/7 is the new and a bit off-topic cleanup, but sys_rt_sigprocmask() looks so annoying
Matt, I didn't dare to keep your reviewed-by tags because of the changes above, hopefully you can re-ack.
Once again: if we need this, then we need a lot more (trivial) changes like 6/7 and 7/7. Basically every change of ->blocked should be converted to use set_current_blocked(). OTOH, perhaps this makes sense by itself.
Oleg.