Documentation/format-patch: more hints on submitting patches
Get series with b4
b4 am 20110415021100.GA19829@elieVersions newest first
- v3 Latest5 patches 11 repliesIn review
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | Documentation: describe the format of messages with inline patchesDocumentation/ | +58 | 2 replies | |
| 2/5 | Documentation: explain how to check for patch corruptionDocumentation/ Documentation/ | +60 | 2 replies | |
| 3/5 | Documentation: hints for sending patches inline with ThunderbirdDocumentation/ Documentation/ | +84 | 0 replies | |
| 4/5 | Documentation: publicize KMail hints for sending patches inlineDocumentation/ Documentation/ | +18 | 1 reply | |
| 5/5 | Documentation: publicize hints for sending patches with GMailDocumentation/ Documentation/ Documentation/ +1 more | +61 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Jim Meyering | Junio C Hamano |
|---|---|---|
| 1/5 | Inspired-by | Improved-by |
| 2/5 | ||
| 3/5 | ||
| 4/5 | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH/RFC v3 0/5] Documentation/format-patch: more hints on submitting patches
Quoted 11 lines · Junio C Hamano
Review
Quoted 3 lines · Jonathan Nieder
(quoted diff) +2
-1-linkgit:git-am[1], linkgit:git-send-email[1] +linkgit:git-am[1], linkgit:git-send-email[1], linkgit:git-imap-send[1], +Documentation/SubmittingPatchesHmm, I suspect this is (1) bad because the end users without the source may not have access to it, and (2) bad because it may indicate that there are hints and tricks in SubmittingPatches file, which narrowly targets developers of this project, but they would also be helpful to the general audience. Perhaps some text needs moving from there to here?
Yep, true. How about this?
Patch 1 explains the "canonical" and "with scissors" formats of mails with patches. It's basically the same as before, except with lots of nice suggestions from Junio incorporated.
Patch 2 explains how new patch submitters can test their tools before unleashing them on the world. It should be common sense, but... The text is taken from Documentation/SubmittingPatches.
Patch 3 is rough; it exposes the Thunderbird MUA-specific hints. Help making it accurate and consistent with git-imap-send(1) would be very much appreciated
Patch 4 contains KMail hints from SubmittingPatches; help would appreciated in making sure that's still accurate, too.
Patch 5 contains the famous GMail hints, finally spreading them out in EXAMPLES sections where they belong.
Maybe this can be a good starting point for future changes.
Jonathan Nieder (5):
Documentation: describe the format of messages with inline patches
Documentation: explain how to check for patch corruption
Documentation: hints for sending patches inline with Thunderbird
Documentation: publicize KMail hints for sending patches inline
Documentation: publicize hints for sending patches with GMail
Documentation/SubmittingPatches | 207 +++------------------------------- Documentation/git-format-patch.txt | 217 ++++++++++++++++++++++++++++++++++++ Documentation/git-imap-send.txt | 29 +++++ Documentation/git-send-email.txt | 19 +++- 4 files changed, 277 insertions(+), 195 deletions(-)