Skip to content

SLUB: Lockless freelists for objects V4

Christoph Lameter lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 0 repliesNew

V2->V3 from the cover letter

- Provide statistics
- Fallback logic to page lock if cmpxchg16b is not available.
- Better counter support
- More cleanups and clarifications

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16slub: Per object NUMA supportmm/slub.c+17 -00 replies
2/16slub: Do not use frozen page flag but a bit in the page countersinclude/linux/mm_types.h include/linux/page-flags.h mm/slub.c+9 -100 replies
3/16slub: Move page->frozen handling near where the page->freelist handling occursmm/slub.c+6 -30 replies
4/16x86: Add support for cmpxchg_doublearch/x86/Kconfig.cpu arch/x86/include/asm/cmpxchg_32.h arch/x86/include/asm/cmpxchg_64.h +1 more+95 -00 replies
5/16mm: Rearrange struct pageinclude/linux/mm_types.h+60 -290 replies
6/16slub: Add cmpxchg_double_slab()include/linux/slub_def.h mm/slub.c+46 -00 replies
7/16slub: explicit list_lock takingmm/slub.c+36 -380 replies
8/16slub: Pass kmem_cache struct to lock and freeze slabmm/slub.c+7 -60 replies
9/16slub: Rework allocator fastpathsmm/slub.c+285 -1290 replies
10/16slub: Invert locking and avoid slab lockmm/slub.c+53 -780 replies
11/16slub: Disable interrupts in free_debug processingmm/slub.c+6 -00 replies
12/16slub: Avoid disabling interrupts in free slowpathmm/slub.c+5 -110 replies
13/16slub: Get rid of the another_slab labelmm/slub.c+5 -60 replies
14/16slub: fast release on full slabmm/slub.c+16 -20 replies
15/16slub: Not necessary to check for empty slab on load_freelistmm/slub.c+2 -30 replies
16/16slub: update statistics for cmpxchg handlinginclude/linux/slub_def.h mm/slub.c tools/slub/slabinfo.c+51 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [slubllv4 00/16] SLUB: Lockless freelists for objects V4

V3->V4 - Diffed against Pekka's slab/next tree plus the ifdef removal patch
(which should be in slab/next soon).
- Numerous cleanups in particular as a result of the removal of the #ifdef CMPXCHG_LOCAL stuff.
- Smaller cleanups whereever I saw something.

V2->V3
- Provide statistics
- Fallback logic to page lock if cmpxchg16b is not available.
- Better counter support
- More cleanups and clarifications

Well here is another result of my obsession with SLAB allocators. There must be some way to get an allocator done that is faster without queueing and I hope that we are now there (maybe only almost...). Any help with cleaning up the rough edges would be appreciated.

This patchset implement wider lockless operations in slub affecting most of the slowpaths. In particular the patch decreases the overhead in the performance critical section of __slab_free.

One test that I ran was "hackbench 200 process 200" on 2.6.29-rc3 under KVM

Run SLAB SLUB SLUB LL
1st 35.2 35.9 31.9
2nd 34.6 30.8 27.9
3rd 33.8 29.9 28.8

Note that the SLUB version in 2.6.29-rc1 already has an optimized allocation and free path using this_cpu_cmpxchg_double(). SLUB LL takes it to new heights by also using cmpxchg_double() in the slowpaths (especially in the kfree() case where we frequently cannot use the fastpath because there is no queue).

The patch uses a cmpxchg_double (also introduced here) to do an atomic change on the state of a slab page that includes the following pieces of information:

1. Freelist pointer
2. Number of objects inuse
3. Frozen state of a slab

Disabling of interrupts (which is a significant latency in the allocator paths) is avoided in the __slab_free case.

There are some concerns with this patch. The use of cmpxchg_double on fields of the page struct requires alignment of the fields to double word boundaries. That can only be accomplished by adding some padding to struct page which blows it up to 64 byte (on x86_64). Comments in the source describe these things in more detail.

The cmpxchg_double() operation introduced here could also be used to update other doublewords in the page struct in a lockless fashion. One can envision page state changes that involved flags and mappings or maybe do list operations locklessly (but with the current scheme we would need to update two other words elsewhere at the same time too, so another scheme would be needed).