Skip to content

SLUB: [RFC] Per cpu partial lists V2

Christoph Lameter lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4slub: Prepare inuse field in new_slab()mm/slub.c+2 -30 replies
2/4slub: pass kmem_cache_cpu pointer to get_partial()mm/slub.c+15 -150 replies
3/4slub: return object pointer from get_partial() / new_slab().mm/slub.c+73 -570 replies
4/4slub: [RFC] per cpu cache for partial pagesinclude/linux/slub_def.h mm/slub.c+243 -470 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [slub p2 0/4] SLUB: [RFC] Per cpu partial lists V2

The following patchset applied on top of the lockless patchset V7. It introduces per cpu partial lists which allow a performance increase of around ~15 during contention for the nodelock (can be tested using hackbench).

These lists help to avoid per nodelocking overhead. Allocator latency could be further reduced by making these operations work without disabling interrupts (like the fastpath and the free slowpath) as well as implementing better ways of handling ther cpu array with partial pages.

I am still not satisfied with the cleanliness of the code after these changes. Some review with suggestions as to how to restructure the code given these changes in operations would be appreciated.

It is interesting to note that BSD has gone to a scheme with partial pages only per cpu (source: Adrian). Transfer of cpu ownerships is done using IPIs. Probably too much overhead for our taste. The use of a few per cpu partial pages looks to be beneficial though.

Note that there is no performance gain when there is no contention.

Performance:

Before After
./hackbench 100 process 200000

				Time: 2299.072	1742.454
./hackbench 100 process 20000
				Time: 224.654	182.393
./hackbench 100 process 20000
				Time: 227.126	182.780
./hackbench 100 process 20000
				Time: 219.608	182.899
./hackbench 10 process 20000
				Time: 21.769	18.756
./hackbench 10 process 20000
				Time: 21.657	18.938
./hackbench 10 process 20000
				Time: 23.193	19.537
./hackbench 1 process 20000
				Time: 2.337	2.263
./hackbench 1 process 20000
				Time: 2.223	2.271
./hackbench 1 process 20000
				Time: 2.269	2.301