Skip to content

More error handling fixes

[email protected] linux-btrfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest23 patches 1 replyIn review
  2. v29 patches 0 repliesSuperseded
  3. v19 patches 5 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23btrfs: Add btrfs_panic()fs/btrfs/ctree.h fs/btrfs/super.c+57 -10 replies
2/23btrfs: Catch locking failures in {set,clear}_extent_bitfs/btrfs/extent_io.c+31 -110 replies
3/23btrfs: Push up set_extent_bit errors to callersfs/btrfs/extent-tree.c fs/btrfs/extent_io.c fs/btrfs/file-item.c +3 more+99 -440 replies
4/23btrfs: Push up lock_extent errors to callersfs/btrfs/compression.c fs/btrfs/disk-io.c fs/btrfs/extent_io.c +5 more+94 -570 replies
5/23btrfs: Push up clear_extent_bit errors to callersfs/btrfs/disk-io.c fs/btrfs/extent-tree.c fs/btrfs/extent_io.c +7 more+142 -800 replies
6/23btrfs: Push up unlock_extent errors to callersfs/btrfs/compression.c fs/btrfs/disk-io.c fs/btrfs/extent_io.c +5 more+159 -1040 replies
7/23btrfs: Make pin_down_extent return voidfs/btrfs/extent-tree.c+3 -40 replies
8/23btrfs: Push up btrfs_pin_extent failuresfs/btrfs/extent-tree.c fs/btrfs/tree-log.c+22 -80 replies
9/23btrfs: btrfs_drop_snapshot should return intfs/btrfs/ctree.h fs/btrfs/extent-tree.c+5 -50 replies
10/23btrfs: Push up non-looped btrfs_start_transaction failuresfs/btrfs/extent-tree.c fs/btrfs/relocation.c fs/btrfs/transaction.c +2 more+21 -80 replies
11/23btrfs: Make set_range_writeback return voidfs/btrfs/extent_io.c+5 -30 replies
12/23btrfs: extent_io.c: Make functions with no error conditions return voidfs/btrfs/extent_io.c fs/btrfs/extent_io.h+13 -220 replies
13/23btrfs: volumes.c: Make functions with no error conditions return voidfs/btrfs/volumes.c fs/btrfs/volumes.h+11 -180 replies
14/23btrfs: async-thread.c: Make functions with no error conditions return voidfs/btrfs/async-thread.c fs/btrfs/async-thread.h+14 -240 replies
15/23btrfs: tree-log.c: Make functions with no error conditions return voidfs/btrfs/tree-log.c fs/btrfs/tree-log.h+3 -50 replies
16/23btrfs: Make btrfs_init_compress return voidfs/btrfs/compression.c fs/btrfs/compression.h fs/btrfs/super.c+3 -70 replies
17/23btrfs: Make btrfs_invalidate_inodes return voidfs/btrfs/ctree.h fs/btrfs/inode.c+2 -30 replies
18/23btrfs: disk-io.c: Make functions with no error conditions return voidfs/btrfs/disk-io.c+5 -90 replies
19/23btrfs: extent-tree.c: Make functions with no error conditions return voidfs/btrfs/ctree.h fs/btrfs/extent-tree.c+13 -150 replies
20/23btrfs: file.c: Make functions with no error conditions return voidfs/btrfs/ctree.h fs/btrfs/file.c+2 -30 replies
21/23btrfs: simplify btrfs_submit_bio_hookfs/btrfs/inode.c+4 -30 replies
22/23btrfs: Factor out tree->ops->merge_bio_hook callfs/btrfs/extent_io.c fs/btrfs/inode.c+17 -50 replies
23/23btrfs: Push up ->submit_bio_hook failuresfs/btrfs/disk-io.c fs/btrfs/extent_io.c fs/btrfs/inode.c+26 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [patch v3 00/23] More error handling fixes

Hi all -

The following 23 patches add more error handling to the btrfs code:

- Add btrfs_panic
- Catch locking failures in {set,clear}_extent_bit
- Push up set_extent_bit errors to callers
- Push up lock_extent errors to callers
- Push up clear_extent_bit errors to callers
- Push up unlock_extent errors to callers
- Make pin_down_extent return void
- Push up btrfs_pin_extent errors to callers
- Push up non-looped btrfs_transaction_start errors to callers

New in this version:
- Make functions with no return value return void (11 patches)
- Simplify btrfs_submit_bio_hook
- Simplify tree_merge_hook by adding a merge_bio helper
- Push up submit_bio_hook failures

Changes since last submission:
- Refreshed against 3.1-rc3.

-Jeff

Signature · 2 lines
Jeff Mahoney
SuSE Labs

Read the cover letter in its thread